Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade build scripts to set proper deployment version for 1.8. #760

Merged
merged 2 commits into from
Nov 28, 2011
Merged

Upgrade build scripts to set proper deployment version for 1.8. #760

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8025e29
Upgrade build scripts to set proper deployment version for 1.8.
sptramer Nov 23, 2011
6abe03e
Fix comments erroneously mentioning 3.1
sptramer Nov 23, 2011
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
5 changes: 1 addition & 4 deletions support/iphone/builder.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1081,7 +1081,7 @@ def log(msg):
# we always target backwards to 3.1 even when we use a later
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We still targeting 3.1?

# version iOS SDK. this ensures our code will run on old devices
# no matter which SDK we compile with
deploy_target = "IPHONEOS_DEPLOYMENT_TARGET=3.1"
deploy_target = "IPHONEOS_DEPLOYMENT_TARGET=4.0"
device_target = 'TARGETED_DEVICE_FAMILY=1' # this is non-sensical, but you can't pass empty string

# clean means we need to nuke the build
Expand Down Expand Up @@ -1128,9 +1128,6 @@ def log(msg):
# Meet the minimum requirements for ipad when necessary
if devicefamily == 'ipad' or devicefamily == 'universal':
device_target="TARGETED_DEVICE_FAMILY=2"
# iPad requires at a minimum 3.2 (not 3.1 default)
if devicefamily == 'ipad':
deploy_target = "IPHONEOS_DEPLOYMENT_TARGET=3.2"
# NOTE: this is very important to run on device -- i dunno why
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this comment need to stay around?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually a leadin to the following comment. ipad shouldn't require armv6, but there were complaints by the system when those symbols weren't included before. This actually requires research outside the scope of just changing the minimum versioning.

We should probably also be separating out the i386, armv6, and armv7 versions of libTiCore (and debugger) to avoid bloat in distributed apps where possible but this is a separate issue as well.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added ticket 6292 to track armv6 issues.

# xcode warns that 3.2 needs only armv7, but if we don't pass in
# armv6 we get crashes on device
Expand Down