Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TIMOB-20196](5_2_X) iOS: ScrollableView is not possible to change views #7627

Merged
merged 1 commit into from Jan 11, 2016

Conversation

AngelkPetkov
Copy link
Contributor

@pec1985
Copy link
Contributor

pec1985 commented Jan 11, 2016

PR reviewed. APPROVED!

pec1985 added a commit that referenced this pull request Jan 11, 2016
[TIMOB-20196](5_2_X) iOS: ScrollableView is not possible to change views
@pec1985 pec1985 merged commit ceac20a into tidev:5_2_X Jan 11, 2016
@@ -71,7 +71,7 @@ -(NSUInteger)viewCount

-(void)setViews:(id)args
{
#ifndef TI_USE_AUTOLAYOUT
#ifdef TI_USE_AUTOLAYOUT
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since this is reverted ~line 74 ifndef to ifdef in the versions 5.1.2 and 5.2.RC now the RE setView() freez the app.

I just tested now withifndefand the app not freez anymore.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @nuno, sounds critical. Can you describe some more details on the related ticket?

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@hansemannn Work on it now.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nuno Changing that line worked for me! Thanks mate!!!

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@hansemannn filed!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants