New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[TIMOB-19165] iOS: Cannot style links in Attributed Strings #7645
Conversation
// require('./ti.utils.test'); | ||
// require('./ti.analytics.test'); | ||
// require('./ti.ui.textfield.test'); | ||
require('./ti.ui.attributedString.test'); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remove these comments, this code needs to run when testing
Addressed Comments :)! |
attrName = NSLinkAttributeName; | ||
attrValue = [TiUtils stringValue:value]; | ||
[self setLink:args]; | ||
return; | ||
break; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
unnecessary break
@AngelkPetkov there's merge conflicts here. can we resolve this soon? |
@cheekiatng Didn't realize it had conflict or that its still open. Closing in favor of #7751 as i was running to some errors when trying to pull and resolve conflicts. |
JIRA