Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TIMOB-19165] iOS: Cannot style links in Attributed Strings #7645

Closed
wants to merge 9 commits into from

Conversation

AngelkPetkov
Copy link
Contributor

// require('./ti.utils.test');
// require('./ti.analytics.test');
// require('./ti.ui.textfield.test');
require('./ti.ui.attributedString.test');
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove these comments, this code needs to run when testing

@AngelkPetkov
Copy link
Contributor Author

Addressed Comments :)!

attrName = NSLinkAttributeName;
attrValue = [TiUtils stringValue:value];
[self setLink:args];
return;
break;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

unnecessary break

@cheekiatng
Copy link
Contributor

@AngelkPetkov there's merge conflicts here. can we resolve this soon?

@AngelkPetkov
Copy link
Contributor Author

@cheekiatng Didn't realize it had conflict or that its still open. Closing in favor of #7751 as i was running to some errors when trying to pull and resolve conflicts.

@pec1985 pec1985 closed this Feb 26, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants