TIMOB-6068 remove hideTabBar from KS Nook #784
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -33,10 +33,6 @@ tableview.addEventListener('click', function(e) | |||
| title:e.rowData.title | |||
| }); | |||
|
|
|||
| if (e.index == 3) | |||
There was a problem hiding this comment.
should this be an iOS only check instead of code deletion?
There was a problem hiding this comment.
We could, but I figured since this is nook-only, I'd just delete it. But I can change if you want.
There was a problem hiding this comment.
Fair point -- There isn't a Nook iOS that I know of :) sounds good to me, let's leave it
|
Code reviewed. Request accepted. |
|
Pull accepted Tested on Nook, verified behavior of window (standalone) not producing crash |
|
Code and functional review passed, Request accepted |
marshall
added a commit
that referenced
this pull request
Nov 30, 2011
TIMOB-6068 remove hideTabBar from KS Nook
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
http://jira.appcelerator.org/browse/TIMOB-6068
Test is the failcase in the app (you should be able to run "Window Standalone" without error).
See description of this "fix".