Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TIMOB-6068 remove hideTabBar from KS Nook #784

Merged
merged 4 commits into from
Nov 30, 2011
Merged

TIMOB-6068 remove hideTabBar from KS Nook #784

Changes from 2 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
e572062
TIMOB-6068 remove hideTabBar from KS Nook
billdawson Nov 29, 2011
0d08eed
Merge branch 'appc_master' into timob-6068
billdawson Nov 30, 2011
ef1972c
Merge branch 'appc_master' into timob-6068
billdawson Nov 30, 2011
3b55b2f
Merge branch 'appc_master' into timob-6068
billdawson Nov 30, 2011
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
4 changes: 0 additions & 4 deletions demos/KitchenSink-Nook/Resources/main_windows/base_ui.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,10 +33,6 @@ tableview.addEventListener('click', function(e)
title:e.rowData.title
});

if (e.index == 3)
{
win.hideTabBar();
}
if (Ti.Platform.name==='android' && e.rowData.test.indexOf('window_properties.js') >= 0) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should this be an iOS only check instead of code deletion?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We could, but I figured since this is nook-only, I'd just delete it. But I can change if you want.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fair point -- There isn't a Nook iOS that I know of :) sounds good to me, let's leave it

// As explained in apidoc for Window, if opacity is ever to be changed for an Android
// activity during its lifetime, it needs to use a translucent background. We trigger
Expand Down