[TIMOB-23684] iOS: Expose properties to hide the navbar #8160
Conversation
|
Can one of the admins verify this patch? |
| @@ -304,6 +304,7 @@ - (void)viewWillAppear:(BOOL)animated; // Called when the view is about to ma | |||
| - (void)viewDidAppear:(BOOL)animated; // Called when the view has been fully transitioned onto the screen. Default does nothing | |||
| { | |||
| [self updateTitleView]; | |||
| [self updateHidesBars]; | |||
There was a problem hiding this comment.
Please fix indentation
There was a problem hiding this comment.
I think someone broke the indentation with tabs.
There was a problem hiding this comment.
tl;dr:
It's a legacy part of the code, where tabs have been used.
The way to go here is to use the pattern that is already there. All new sources have spaces by default, but some old one have tabs. The only reason we don't run a script to fix it to spaces everywhere is, to not loose the ability to git-blame the source, because it sometimes can be very important to see why a certain change was made back in the days.
|
Did a quick review, looks good just some minor changes to be addressed. Also could you please provide a javaScript demo-code for the FT. EDIT: Please also provide the docs update. Feature freeze for 6.0.0 is approaching (Friday). If all changes are addressed prior this could make it in 6.0.0, otherwise it goes in 6.1.0. |
hansemannn
changed the title
hansemannn
changed the title
| [self updateHidesBarsOnSwipe]; | ||
| [self updateHidesBarsOnTap]; | ||
| [self updateHidesBarsWhenVerticallyCompact]; | ||
| [self updateHidesBarsWhenKeyboardAppears]; |
There was a problem hiding this comment.
Indentation again. And do we need to call these on appear as well? I would expect that is already gets set by the setters used and the default behavior for the remaining ones.
There was a problem hiding this comment.
We need to call because you can pass on constructor, not?
There was a problem hiding this comment.
Ok, you're right, no need to do that.
|
@hansemannn and @AngelkPetkov - fixed and added doc in YML. |
| type: Boolean | ||
| default: false | ||
| since: 6.0.0 | ||
| osver: {ios: "8.0"} |
There was a problem hiding this comment.
This is invalid. Check my comment again, it's
osver: {ios: {min: "8.0"}}
|
We can merge as soon the demo-code is provided in JIRA |
|
Approved! |
|
@hansemannn There is a constant warning with: I commited again, could you reopen the PR? |
|
Shit, why did it work during feature-test? It needs to be ourNC.hidesBarsWhenVerticallyCompact = [TiUtils boolValue:value def:NO];for all methods. Will correct it |
|
I commited with The warning is about the |
|
Well, it is correct as it is. All methods expect a boolean value like natively. |
JIRA: https://jira.appcelerator.org/browse/TIMOB-23684
Exposed the methods described above:
https://developer.apple.com/library/ios/documentation/UIKit/Reference/UINavigationController_Class/#//apple_ref/doc/uid/TP40006934-CH3-SW36