Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TIMOB-14285] Fix kroll-v8::nativeSetProperty() to set accessor #8557

Merged
merged 1 commit into from Nov 17, 2016

Conversation

garymathews
Copy link
Contributor

@garymathews garymathews commented Oct 27, 2016

  • nativeSetProperty() does not set an accessor for custom properties, making them unavailable in JavaScript
TEST CASE
var win = Ti.UI.createWindow();
win.open();
win.applyProperties({customString: 'TEST'});
Ti.API.info('customString: ' + win.customString);
// customString should output 'TEST'

JIRA Ticket

@sgtcoolguy
Copy link
Contributor

Can we add a unit test for this? Do other platforms support this? I think Windows does...

@garymathews
Copy link
Contributor Author

I'll add test, but this does not only affect applyProperties. Any internal calls to setProperty would fail if it is to set properties that are not defined by a Titanium proxy.

@garymathews
Copy link
Contributor Author

garymathews commented Nov 8, 2016

@sgtcoolguy
Copy link
Contributor

test this please

@garymathews
Copy link
Contributor Author

Tests are passing 👍

@sgtcoolguy sgtcoolguy merged commit 0f2314c into tidev:master Nov 17, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants