Skip to content

Commit

Permalink
[TIMOB-14285] Fix kroll-v8::nativeSetProperty() to set accessor (#8557)
Browse files Browse the repository at this point in the history
  • Loading branch information
Gary Mathews authored and sgtcoolguy committed Nov 17, 2016
1 parent 3e7f2ae commit 0f2314c
Showing 1 changed file with 2 additions and 1 deletion.
3 changes: 2 additions & 1 deletion android/runtime/v8/src/native/V8Object.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -55,8 +55,9 @@ Java_org_appcelerator_kroll_runtime_v8_V8Object_nativeSetProperty

Local<Object> properties = jsObject->Get(titanium::Proxy::propertiesSymbol.Get(V8Runtime::v8_isolate)).As<Object>();
Local<Value> jsName = TypeConverter::javaStringToJsString(V8Runtime::v8_isolate, env, name);

Local<Value> jsValue = TypeConverter::javaObjectToJsValue(V8Runtime::v8_isolate, env, value);

jsObject->SetAccessor(jsName->ToString(V8Runtime::v8_isolate), titanium::Proxy::getProperty, titanium::Proxy::onPropertyChanged);
properties->Set(jsName, jsValue);
}

Expand Down

0 comments on commit 0f2314c

Please sign in to comment.