TIMOB-19629 Android: user defined letter case for button text #8572
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
frankieandone
force-pushed
the
timob-19629
branch
from
413969c
to
516627b
Compare
hansemannn
reviewed
Nov 2, 2016
| - name: textAllCaps | ||
| summary: | | ||
| All text to upper case letters, specified using true or false. | ||
| type: [boolean] |
garymathews
reviewed
Nov 3, 2016
| @@ -130,6 +131,12 @@ public void processProperties(KrollDict d) | |||
| if (needShadow) { | |||
| btn.setShadowLayer(shadowRadius, shadowX, shadowY, shadowColor); | |||
| } | |||
| if (d.containsKey(TiC.PROPERTY_TEXT_ALL_CAPS)){ | |||
| boolean caps = TiConvert.toBoolean(d.get(TiC.PROPERTY_TEXT_ALL_CAPS)); | |||
There was a problem hiding this comment.
Set a default value to fall back onto
boolean caps = TiConvert.toBoolean(d.get(TiC.PROPERTY_TEXT_ALL_CAPS), false);
garymathews
reviewed
Nov 3, 2016
| if (Build.VERSION.SDK_INT >= Build.VERSION_CODES.ICE_CREAM_SANDWICH) { | ||
| btn.setAllCaps(caps); | ||
| } | ||
| } | ||
| btn.invalidate(); | ||
| } | ||
|
|
There was a problem hiding this comment.
You should also add a similar setter to propertyChanged
...
} else if (key.equals(TiC.PROPERTY_TEXT_ALL_CAPS)) {
boolean caps = TiConvert.toBoolean(d.get(TiC.PROPERTY_TEXT_ALL_CAPS), false);
if (Build.VERSION.SDK_INT >= Build.VERSION_CODES.ICE_CREAM_SANDWICH) {
btn.setAllCaps(caps);
}
...
frankieandone
force-pushed
the
timob-19629
branch
3 times, most recently
from
08fc27a
to
c73e1d1
Compare
|
So looking at the ticket, the issue is to do with the |
frankieandone
force-pushed
the
timob-19629
branch
from
c73e1d1
to
28350b2
Compare
|
There are 3 fixes available which this is one #1.
|
|
Superseded by #8592 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JIRA: https://jira.appcelerator.org/browse/TIMOB-19629