Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TIMOB-19629] Use application theme as parent for Theme.Titanium #8592

Merged
merged 1 commit into from
Nov 10, 2016

Conversation

garymathews
Copy link
Contributor

@garymathews garymathews commented Nov 8, 2016

  • When an application theme is defined in tiapp.xml make sure the parent of Theme.Titanium is set as this theme
TEST CASE
tiapp.xml
...
<android xmlns:android="http://schemas.android.com/apk/res/android">
    <manifest android:versionCode="1" android:versionName="1.0">
        <application android:theme="@style/Theme.Test"/>
    </manifest>
</android>
...
platform/android/res/values/test.xml
<?xml version="1.0" encoding="utf-8"?>
<resources xmlns:android="http://schemas.android.com/apk/res/android">
    <style name="Theme.Test" parent="@style/Theme.AppCompat">
        <item name="android:textAllCaps">false</item>
    </style>
</resources>
app.js
var win = Ti.UI.createWindow(),
	btn = Ti.UI.createButton({title: 'lower case'}),
	lv = Ti.UI.createListView();

lv.appendSection(Ti.UI.createListSection({
	headerView: btn
}));
win.add(lv);
win.open();

For Android 5.0+, the lower case title of the button should NOT be uppercase.

JIRA Ticket

@garymathews garymathews added this to the 6.1.0 milestone Nov 8, 2016
@garymathews garymathews added the cli label Nov 8, 2016
@frankieandone frankieandone merged commit e0ddfd8 into tidev:master Nov 10, 2016
jquick-axway added a commit to jquick-axway/titanium_mobile that referenced this pull request Jul 25, 2017
…nium" no longer causes a recursive lookup.

- Modified "Theme.Titanium" to no longer use the AndroidManifest.xml <application> tag's  theme as its parent.
  * This was the cause of the recursion if the custom theme was applied to the application.
  * Fixed by reverting PR tidev#8592 (ie: TIMOB-19629).
- Also fixed ListView to correctly apply its activity's theme to its rows, headers, and footers.
  * This addresses the bug for PR tidev#8592 that I reverted.
jquick-axway added a commit to jquick-axway/titanium_mobile that referenced this pull request Jul 25, 2017
…nium" no longer causes a recursive lookup.

- Modified "Theme.Titanium" to no longer use the AndroidManifest.xml <application> tag's  theme as its parent.
  * This was the cause of the recursion if the custom theme was applied to the application.
  * Fixed by reverting PR tidev#8592 (ie: TIMOB-19629).
- Also fixed ListView to correctly apply its activity's theme to its rows, headers, and footers.
  * This addresses the bug for PR tidev#8592 that I reverted.
jquick-axway added a commit to jquick-axway/titanium_mobile that referenced this pull request Jul 25, 2017
…nium" no longer causes a recursive lookup.

- Modified "Theme.Titanium" to no longer use the AndroidManifest.xml <application> tag's  theme as its parent.
  * This was the cause of the recursion if the custom theme was applied to the application.
  * Fixed by reverting PR tidev#8592 (ie: TIMOB-19629).
- Also fixed ListView to correctly apply its activity's theme to its rows, headers, and footers.
  * This addresses the bug for PR tidev#8592 that I reverted.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants