[TIMOB-20286] iOS/Android: Expose Ti.UI.View.getViewById method #8677
Conversation
hansemannn
changed the title
| * @module.api | ||
| */ | ||
| @Kroll.method | ||
| public TiViewProxy getViewById(Object arg) |
There was a problem hiding this comment.
public TiViewProxy getViewById(String id)
// no need to use
TiConvert.toString(arg)
| } | ||
| } | ||
|
|
||
| if (child.getProperty(TiC.PROPERTY_ID) != null && child.getProperty(TiC.PROPERTY_ID).equals(TiConvert.toString(arg))) { |
There was a problem hiding this comment.
if (child.hasProperty(TiC.PROPERTY_ID) && child.getProperty(TiC.PROPERTY_ID).equals(id)) {
|
@garymathews Updated PR! |
| } | ||
| } | ||
|
|
||
| if (child.getProperty(TiC.PROPERTY_ID) && child.getProperty(TiC.PROPERTY_ID).equals(arg)) { |
There was a problem hiding this comment.
Builds failing, getProperty should be hasProperty
if (child.hasProperty(TiC.PROPERTY_ID) && child.getProperty(TiC.PROPERTY_ID).equals(id)) {There was a problem hiding this comment.
But hasProperty returns a boolean and getProperty the property itself. Please go ahead and edit it
There was a problem hiding this comment.
Yes, but you can only perform an && operation on a Boolean in Java. So either:
if (child.hasProperty(TiC.PROPERTY_ID) && child.getProperty(TiC.PROPERTY_ID).equals(id)) {
// OR
if (child.getProperty(TiC.PROPERTY_ID) != null && child.getProperty(TiC.PROPERTY_ID).equals(id)) {There was a problem hiding this comment.
But that's how it was before all that. You can edit it on Github, so we can ensure it doesn't cause problems again.
There was a problem hiding this comment.
I see, I think you might have missed my change to hasProperty here
There was a problem hiding this comment.
Gotcha, changed it. But the original implementation was like the second suggestion above already (except the string-casting), that's why I wondered. Sorry for the confusion, let's finish this 🙂
| * @module.api | ||
| */ | ||
| @Kroll.method | ||
| public TiViewProxy getViewById(String arg) |
There was a problem hiding this comment.
String id // same name as docsThere was a problem hiding this comment.
Does this work on Android? id is a type on iOS. Will change it here, but primarily followed other method argument lists.
|
CR: PASS 👍 |
JIRA: https://jira.appcelerator.org/browse/TIMOB-20286