[TIMOB-19040] :Replace MPMoviePlayerController in Ti.Media.VideoPlayer with AVPlayerViewController #8721

vijaysingh-axway · 2016-12-30T07:53:37Z

https://jira.appcelerator.org/browse/TIMOB-19040

into TIMOB-19040

into TIMOB-19040 # Conflicts: # iphone/iphone/Titanium.xcodeproj/project.pbxproj

… TIMOB-19040 # Conflicts: # iphone/Classes/MediaModule.m # iphone/Classes/TiMediaVideoPlayer.m # iphone/Classes/TiMediaVideoPlayerProxy.m # iphone/iphone/Titanium.xcodeproj/project.pbxproj

… TIMOB-19040 # Conflicts: # iphone/Classes/MediaModule.m # iphone/Classes/TiMediaVideoPlayerProxy.m

hansemannn · 2017-11-01T12:31:45Z

iphone/Classes/MediaModule.m

@@ -458,6 +423,28 @@ - (void)setAudioSessionMode:(NSNumber *)mode
  }
 }

+- (NSNumber *)audioSessionMode


@vijaysingh-axway You added this API but deprecated it as well? Please clarify here.

@hansemannn Good catch! This method was added by you in your initial change for this ticket. I think it is not needed here as audioSessionCategory is already there. Even variables AUDIO_SESSION_MODE_* are also not defined there. So removed this method. Thanks.

hansemannn · 2017-11-01T12:32:27Z

iphone/Classes/TiMediaVideoPlayerProxy.h

@@ -45,6 +49,7 @@
 @property (nonatomic, readwrite, assign) TiColor *backgroundColor;
 @property (nonatomic, readonly) NSNumber *playing;
 @property (nonatomic, copy) NSNumber *volume;
+@property (nonatomic, readwrite, assign) id pictureInPictureEnabled;


Should be NSNumber if public API. BOOL otherwise.

Made it NSNumber.

hansemannn

Some more issues I found during testing. Please also remove the demos/KitchenSink/Resources/another.mp4 file and add an example to the kitchensink-v2 instead.

hansemannn · 2017-11-07T16:26:52Z

iphone/Classes/TiMediaVideoPlayerProxy.m

+
+      // Handle both setting this value on running videos and on creation
+      if ([[movie player] status] == AVPlayerStatusReadyToPlay) {
+        [[movie player] seekToTime:CMTimeMake(ourTime, 1)];


This does not work. Try to use

[[movie player] seekToTime:CMTimeMake(ourTime, 1) toleranceBefore:kCMTimeZero toleranceAfter:kCMTimeZero];

instead.

build · 2017-11-13T07:53:57Z

	Fails
🚫	🔬 There are library changes, but no changes to the unit tests. That's OK as long as you're refactoring existing code, but will require an admin to merge this PR. Please see README.md#unit-tests for docs on unit testing.

Generated by 🚫 dangerJS

hansemannn · 2017-11-13T07:57:55Z

iphone/Classes/TiMediaVideoPlayerProxy.h

 @interface TiMediaVideoPlayerProxy : TiViewProxy {
  @protected
  AVPlayerViewController *movie;
+  MPMoviePlayerViewController *cont;


Why did you add the deprecated API again here?

hansemannn · 2017-11-13T07:58:06Z

iphone/Classes/TiMediaVideoPlayerProxy.h

+enum {
+  VideoTimeOptionNearestKeyFrame = 0,
+  VideoTimeOptionExact,
+};


Use NS_Enums.

hansemannn · 2017-11-13T08:00:57Z

Please also add unit-tests here, there are none so far. The tests can be pretty straight forward with the test-suite you provided earlier.

hansemannn · 2017-11-13T08:09:24Z

iphone/Classes/MediaModule.h

+@property(nonatomic,readonly) NSNumber* VIDEO_CONTROL_NONE;			// No controls
+@property(nonatomic,readonly) NSNumber* VIDEO_CONTROL_EMBEDDED;		// Controls for an embedded view
+@property(nonatomic,readonly) NSNumber* VIDEO_CONTROL_FULLSCREEN;	// Controls for fullscreen playback
+*/


Remove this comment.

hansemannn · 2017-11-13T11:47:33Z

apidoc/Titanium/Media/Media.yml

+    deprecated:
+        since: '7.0.0'
+        notes: This property has been removed for iOS in Titanium SDK 7.0.0 as of the official deprecation by Apple.
+        removed: '7.0.0'


Are single quotes ok in the docs? We usually use ". Please validate the docs locally again. cc @jawa9000

Very few places single quotes are there. I updated to ".

hansemannn · 2017-11-13T11:48:20Z

apidoc/Titanium/Media/Media.yml

@@ -1265,17 +1277,30 @@ properties:
    type: Number
    permission: read-only
    platforms: [android, iphone, ipad]
+  - name: VIDEO_LOAD_STATE_FAILED
+    summary: Indicates that the player can no longer play AVPlayerItem instances because of an error.


Titanium users have no idea what a AVPlayerItem is. Use "media items" instead.

hansemannn · 2017-11-13T11:48:44Z

apidoc/Titanium/Media/Media.yml

    summary: Video scaling is disabled.
    type: Number
    permission: read-only
+  - name: VIDEO_SCALING_RESIZE
+    summary: Specifies that the video should be stretched to fill the layer’s bounds.


That ’ probably fails validation.

hansemannn · 2017-11-14T17:26:39Z

@vijaysingh-axway Can you please re-publish your branch? It was accidentally merged and I did not test the latest changes so far. Thanks!

hansemannn and others added 30 commits July 8, 2015 15:52

Merge branch 'master' of https://github.com/appcelerator/titanium_mobile

282ebef

Merge branch 'master' of https://github.com/appcelerator/titanium_mobile

8673080

[TIMOB-19040] MPMoviePlayer deprecation 1

746f1c7

[TIMOB-19040] MPMoviePlayer deprecation 1

d8e8a32

Merge branch 'master' of https://github.com/appcelerator/titanium_mobile

6f35822

into TIMOB-19040

[TIMOB-19040] MPMoviePlayer deprecation 2

923cb51

Merge master

c48fd4e

Merge branch 'master' of https://github.com/appcelerator/titanium_mobile

d0bec83

into TIMOB-19040 # Conflicts: # iphone/iphone/Titanium.xcodeproj/project.pbxproj

[TIMOB-19040] MPMoviePlayer deprecation 3

49e9210

Restore KitchenSink app.js

ae29a97

[TIMOB-19040] MPMoviePlayer deprecation 4

d5e62d6

[TIMOB-19040] MPMoviePlayer deprecation 4

70d2990

Update events / observer

5ad6fa9

Support iOS9 PiP, resizing, play, pause & stop

f5589c4

Remove deprecated methods, support autoplay

e5651d9

Improve iOS8 backward compatibility

f2a7575

Add another sample video to KitchenSink

e2d934e

Re-support thumbnail generation

1ca221b

Re-support initialPlaybackTime, fullscreen mode

b2ccd83

[TIMOB-19040] Add more functionality, adjust style

9dc5fec

Merge branch 'master' of github.com:appcelerator/titanium_mobile into…

bff3571

… TIMOB-19040 # Conflicts: # iphone/Classes/MediaModule.m # iphone/Classes/TiMediaVideoPlayer.m # iphone/Classes/TiMediaVideoPlayerProxy.m # iphone/iphone/Titanium.xcodeproj/project.pbxproj

Merge branch 'master' of github.com:appcelerator/titanium_mobile into…

5ad1550

… TIMOB-19040 # Conflicts: # iphone/Classes/MediaModule.m # iphone/Classes/TiMediaVideoPlayerProxy.m

Merge branch 'PR-8194' into TIMOB-19040

b420867

[TIMOB-19040]:iOS9: Replace MPMoviePlayerController in

e18eb16

[TIMOB-19040]:added showSontrols property added

28503a8

overlayview addition property exposed.

0539dc9

[TIMOB-19040]: iOS Overlayview added and deprecated properties removed.

1010932

[TIMOB-19040]: Deprecated properties removed.

e4375e0

[TIMOB-19040]: player status property added

d5075a2

[TIMOB-19040]: Unnecesssary properties removed

89085e8

hansemannn added 2 commits November 1, 2017 13:26

Update VideoPlayer.yml

5e563f3

Update MediaModule.m

d348213

hansemannn requested changes Nov 1, 2017

View reviewed changes

vijaysingh-axway and others added 3 commits November 2, 2017 11:08

[TIMOB-19040] : audiosessionmode method removed

8212744

Merge branch 'master' into TIMOB-19040

1e3809d

Merge branch 'master' into TIMOB-19040

7716bbc

hansemannn requested changes Nov 7, 2017

View reviewed changes

vijaysingh-axway added 7 commits November 8, 2017 12:10

Merge branch 'master' into TIMOB-19040

cf93d99

[TIMOB-19040] : Fix setInitialPlaybackTime issue

82f6805

[TIMOB-19040] : linting issue fixed

5fd0bd8

[TIMOB-19040] : demos/KitchenSink/Resources/another.mp4

f5e9068

[TIMOB-19040] : Doc updated

a8a0e18

[TIMOB-19040] : requestThumbnailImagesAtTimes supported

446f703

Merge branch 'master' into TIMOB-19040

5554f12

build added docs ios labels Nov 13, 2017

hansemannn requested changes Nov 13, 2017

View reviewed changes

hansemannn reviewed Nov 13, 2017

View reviewed changes

[TIMOB-19040] : Doc updated

3ea12ad

hansemannn reviewed Nov 13, 2017

View reviewed changes

hansemannn requested changes Nov 13, 2017

View reviewed changes

vijaysingh-axway added 3 commits November 14, 2017 08:55

[TIMOB-19040] : Updated docs

30ba65f

[TIMOB-19040] : Special character removed from doc

9f1795a

[TIMOB-19040] : Unit tests added

21a2c7e

eric34 merged commit 3f4055f into tidev:master Nov 14, 2017

eric34 mentioned this pull request Nov 14, 2017

Revert "[TIMOB-19040] :Replace MPMoviePlayerController in Ti.Media.VideoPlayer with AVPlayerViewController" #9598

Merged

hansemannn mentioned this pull request Nov 14, 2017

iOS: Replace MPMoviePlayerController with AVPlayerViewController #9599

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[TIMOB-19040] :Replace MPMoviePlayerController in Ti.Media.VideoPlayer with AVPlayerViewController #8721

[TIMOB-19040] :Replace MPMoviePlayerController in Ti.Media.VideoPlayer with AVPlayerViewController #8721

vijaysingh-axway commented Dec 30, 2016

hansemannn Nov 1, 2017

vijaysingh-axway Nov 2, 2017

hansemannn Nov 1, 2017

vijaysingh-axway Nov 2, 2017

hansemannn left a comment

hansemannn Nov 7, 2017

build commented Nov 13, 2017

hansemannn Nov 13, 2017

hansemannn Nov 13, 2017

hansemannn commented Nov 13, 2017

hansemannn Nov 13, 2017

hansemannn Nov 13, 2017

vijaysingh-axway Nov 14, 2017

hansemannn Nov 13, 2017

hansemannn Nov 13, 2017

vijaysingh-axway Nov 14, 2017 •

edited

hansemannn commented Nov 14, 2017

[TIMOB-19040] :Replace MPMoviePlayerController in Ti.Media.VideoPlayer with AVPlayerViewController #8721

[TIMOB-19040] :Replace MPMoviePlayerController in Ti.Media.VideoPlayer with AVPlayerViewController #8721

Conversation

vijaysingh-axway commented Dec 30, 2016

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

hansemannn left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

build commented Nov 13, 2017

Choose a reason for hiding this comment

Choose a reason for hiding this comment

hansemannn commented Nov 13, 2017

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

vijaysingh-axway Nov 14, 2017 • edited

Choose a reason for hiding this comment

hansemannn commented Nov 14, 2017

vijaysingh-axway Nov 14, 2017 •

edited