Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TIMOB-24313] iOS/Android: Expose Ti.UI.ImageView.aspectFill #8755

Closed
wants to merge 1 commit into from

Conversation

kopiro
Copy link
Contributor

@kopiro kopiro commented Jan 16, 2017

@build
Copy link
Contributor

build commented Jan 16, 2017

Can one of the admins verify this patch?

@kopiro kopiro changed the title iOS: Added aspectFill option Added aspectFill option Jan 16, 2017
@kopiro
Copy link
Contributor Author

kopiro commented Jan 16, 2017

I'm working to implement it in Android

@kopiro kopiro changed the title Added aspectFill option iOS/Android: Added aspectFill option Jan 16, 2017
@hansemannn hansemannn changed the title iOS/Android: Added aspectFill option [TIMOB-24313] iOS/Android: Expose Ti.UI.ImageView.aspectFill Jan 16, 2017
@hansemannn hansemannn added this to the 6.2.0 milestone Jan 16, 2017
@hansemannn
Copy link
Collaborator

hansemannn commented Aug 11, 2017

Hey @kopiro, after discussing this with the team, we should rather go with a more flexible solution to allow all other possible content-mode properties, see here for details. Do you want to address that change or can we help?

@hansemannn hansemannn modified the milestones: 7.0.0, 6.2.0 Aug 15, 2017
@sgtcoolguy sgtcoolguy modified the milestones: 7.0.0, 7.1.0 Nov 30, 2017
@sgtcoolguy
Copy link
Contributor

@hansemannn @kopiro Is this PR dead? Is there another PR or effort that supersedes this one (and this can be closed)?

@hansemannn
Copy link
Collaborator

Closing due to merge conflicts and stale discussion. I still think it'd be a good idea to do the change, but we have to do it more flexible as I see problems regarding some existing use-cases already.

@hansemannn hansemannn closed this Feb 15, 2018
@hansemannn hansemannn removed this from the 7.1.0 milestone Feb 15, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants