-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[TIMOB-24347] Android: Fix URI handling for TiThumbnailRetriever #8830
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
After Using the test case to verify code changes here are the findings:
- The import for TitaniumBlob didnt not automatically appear when pulling code from PR, please double check as i cannot find it in the PR
relates to file:VideoPlayerProxy.java
however after testing with that change, i can confirm that it works
URL is perfectly working although getting issues with the intent, when click on intent it says theres nothing on the device not sure why as it worked the last time i tested it |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Intent does not work please look at comment for issue
@antw12 You may have deleted the video from your gallery, download any H.264 MP4 video and try? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
FR passed.
Tested using the test case above and added the permissions for a 6.0+ devices, It now works as expected, spoke to @antw12 about his issue and it is working now.
ENV
SDK Version : Local 6.1.0
Mac OS Version : 10.12.3
Appc CLI : 6.1.0
Appc NPM : 4.2.9-1
Node : v4.6.0
Device: Nexus 5x(6.0.1) Pixel XL(7.1.1)
Emulator: (6.0), (4.4.2)
TiThumbnailRetriever
requestThumbnailImagesAtTimes()
getNativePath()
intoTitaniumBlob
TEST CASE
Resources
folderJIRA Ticket