[TIMOB-24479] Android: fix TiUILabel maxLines not working

[frankieandone]

Test Case:
Expect the long string to be in one line meaning no word wraps.

var win = Ti.UI.createWindow({
	theme: "Theme.AppCompat.Fullscreen",
	backgroundColor: '#fff'
});
var longString = "Welcome to the Appcelerator Platform! The Appcelerator Platform extends Appcelerator's Titanium platform to help you manage the entire lifecycle of the application with debugging, testing, deployment, crash monitoring and analytic data collection.";
var bigLabel = Ti.UI.createLabel({
	text: longString,
	color: '#4d4d4d',
	width: "90%",
	top: 0,
	maxLines: 1
});
win.add(bigLabel);
win.open();

JIRA: https://jira.appcelerator.org/browse/TIMOB-24479

[antw12]

CR & FT PASS

[hansemannn]

Did you do the backport manually? I don't see this line in the backport, so I was wondering. Try to cherry-pick all changes for consistency.

[frankieandone]

Yes, I did the backport manually which is linked here.

[garymathews]

@fmerzadyan Do we know what broke this in 6.0.0? I'm curious why we now need to refresh maxLines.

[garymathews]

@fmerzadyan I think the problem is with wordWrap defaulting to true. So when maxLines of 1 is specified, the label enables wordWrap after setting maxLines, causing the line to wrap.

Try moving maxLines so it is processed after wordWrap

if (d.containsKey(TiC.PROPERTY_WORD_WRAP)) {
	wordWrap = TiConvert.toBoolean(d, TiC.PROPERTY_WORD_WRAP, true);
	tv.setSingleLine(!wordWrap);
}
if (d.containsKey(TiC.PROPERTY_MAX_LINES)) {
	tv.setMaxLines(TiConvert.toInt(d, TiC.PROPERTY_MAX_LINES));
}

[frankieandone]

@garymathews, the problem is that setSingleLine resets the maxLines property and setSingleLine method is used in multiple places in TiUILabel so the fix was to address those situations now rather than have this problem possibly come up in the future.

[garymathews]

@fmerzadyan I think it would be best to just move maxLines to be set after all of the properties that use setSingleLine and leave a comment to explain why maxLines should be processed last. This will fix all scenarios without requiring a method to be called after the use of setSingleLine.

[frankieandone]

@garymathews, No problem 👍

[antw12]

CR & FT PASS with new changes

[ssjsamir]

FR Passed was able to set a long string to 1 line.

Steps taken to test

• Copied the test case in the description
• Pasted the code into a titanium project in appcelerator studio
• Ran the program on device
• Saw that string was set to one line as part of the string was missing

Environment
Appcelerator Command-Line Interface, version 6.1.0
Nexus 6P (7.1.1)
Operating System Name: Mac OS X El Capitan
Operating System Version: 10.11.6
Node.js Version: 4.6.0
npm: 4.2.8
Xcode: 8.2
Appcelerator Studio: 4.8.1.201612050850