Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[6_0_X][TIMOB-24165] Set custom theme on TiTranslucentActivity #8911

Merged
merged 2 commits into from Mar 28, 2017
Merged

[6_0_X][TIMOB-24165] Set custom theme on TiTranslucentActivity #8911

merged 2 commits into from Mar 28, 2017

Conversation

garymathews
Copy link
Contributor

@garymathews garymathews commented Mar 27, 2017 •
edited

@frankieandone
Copy link
Contributor

frankieandone commented Mar 27, 2017 •
edited

CR and FR PASSED.
Update: Tested in IntelliJ however I got different results than @lokeshchdhry. Just to be safe, it's best to fail PR.

@frankieandone frankieandone self-requested a review March 27, 2017 18:54
@lokeshchdhry
Copy link
Contributor

lokeshchdhry commented Mar 27, 2017 •
edited

FR Failed.

I can still see the actionBar with 6.0.4. Master works fine.
Double verfied it with @longton95.

Device: Nexus 6 android 6.0.1
Emulator: Android 4.4.2, android 4.2.2, android 6.0, android 7.0

@lokeshchdhry
Copy link
Contributor

FR Passed.

actionBar gets removed when using a custom theme & window background color is transparent.

Appc Studio : 4.8.1.201612050850
SDK Version : Locally built 6.0.4
Mac OS Version : 10.12.3
Xcode Version : Xcode 8.2.1 Build version 8C1002
Appc CLI AND Appc NPM : {"NPM":"4.2.8","CLI":"6.1.0"}
Ti CLI : 5.0.11
Alloy : 1.9.5
Node : v4.6.0
Device: Nexus 6 - 6.0.1
Emulator: Android 6.0.1, android 7.0, android 4.2.2

@lokeshchdhry lokeshchdhry merged commit cee61d6 into tidev:6_0_X Mar 28, 2017
@hansemannn hansemannn added this to the 6.0.4 milestone Mar 29, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lokeshchdhry lokeshchdhry Awaiting requested review from lokeshchdhry

@frankieandone frankieandone Awaiting requested review from frankieandone

Assignees
No one assigned
Labels
android bug in-qe-testing 🕵
Projects
None yet
Milestone
6.0.4
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@garymathews @frankieandone @lokeshchdhry @hansemannn