Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TIMOB-24465] Android: Use ARGB_8888 by default #8978

Merged
merged 4 commits into from May 2, 2017

Conversation

garymathews
Copy link
Contributor

TEST CASE
var win = Titanium.UI.createWindow({backgroundColor: 'white'}),
    imageView = Ti.UI.createImageView({
        image: 'https://jira.appcelerator.org/secure/attachment/62074/gradient.png',
        height: '300dp',
        width: '300dp'
    });
win.add(imageView);
win.open();

JIRA Ticket

Copy link
Contributor

@jquick-axway jquick-axway left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved

@ssjsamir
Copy link
Contributor

ssjsamir commented May 1, 2017

FR Passed - Using the test case provided in the description of JIRA Ticket. I used that test case as the image included was more clear for me to view the changes that the test case provided in the description above.

Test steps

  • Downloaded the example project from JIRA Ticket
  • Imported the project in to Appcelerator Studio
  • Ran the program with the SDK built from this PR
  • Compared the image in the application with older SDK
  • Saw the changes that the image was more clear with the SDK built form this PR

Before, screenshot from device: (6.4.0.GA)

before fix

After, screenshot from device: (This PR - Mater build (6.2.0))

after fix

Environment

Appcelerator Command-Line Interface, version 6.2.0
Nexus 6P device (Android 7.1.2)
Operating System Name: Mac OS X El Capitan
Operating System Version: 10.11.6
Node.js Version: 4.6.0
npm: 4.2.8
Xcode: 8.2
Appcelerator Studio: 4.8.1.201612050850

@ssjsamir ssjsamir closed this May 1, 2017
@ssjsamir ssjsamir reopened this May 1, 2017
@ssjsamir
Copy link
Contributor

ssjsamir commented May 1, 2017

Closed by accident^ (miss clicked)

@ssjsamir ssjsamir merged commit 30a9911 into tidev:master May 2, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants