Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TIMOB-24446] Allow replacing bundled Android Support Libraries #9008

Merged
merged 15 commits into from Nov 10, 2017

Conversation

janvennemann
Copy link
Contributor

@janvennemann janvennemann commented May 2, 2017

JIRA: https://jira.appcelerator.org/browse/TIMOB-24446

Optional Description:
This allows a user to replace our bundled Android Support Libraries with one of their own choosing, either from a module or from the project's platform/android folder.

This relies on #8792 and #9027, so only merge after those two PRs.

@garymathews garymathews self-requested a review May 16, 2017 16:32
@hansemannn
Copy link
Collaborator

hansemannn commented May 19, 2017

@janvennemann Please document this new feature in our wikis, so developer know how to replace libraries. Maybe even an own guide on how to do it and some background on what is done internally to select and merge the libraries. You can create a new TIDOC-ticket to handle that.

@janvennemann
Copy link
Contributor Author

janvennemann commented May 19, 2017

@hansemannn i was planning on doing exactly that next. I will add a whole new section to the Android Module Development Guide explaining the .aar handling, including the Support Library override.

Fixes an issue with Hyperloop 2.1.0 which causes a crash when trying to override the Android Support Libraries with local .aar files. Hyperloop 2.1.0 will always manually add our bundled Android Support Libraries to the dexer paths even if they were replaced by the builder. To fix this we check the altered dexer paths again and remove any replaced libraries.
Copy link
Contributor

@garymathews garymathews left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CR: PASS

👍

@janvennemann
Copy link
Contributor Author

janvennemann commented Jul 21, 2017

@garymathews i just updated this PR to also allow the design support libraries to be replaced because they are now part of our bundled support libraries as of #9027

@sgtcoolguy
Copy link
Contributor

Relates to #9258

@lokeshchdhry lokeshchdhry merged commit d877ab0 into tidev:master Nov 10, 2017
@hansemannn
Copy link
Collaborator

I think this PR or one related causes linting issues:

/Users/build/jenkins/workspace/sdk_titanium_mobile_PR-9556-SYYMULLJBPTOYKQ4LBGV23OAGC75PMAHFNU4OMUO5E5XUVZIED7Q/android/cli/commands/_build.js
  1636:9  warning  Blocks are nested too deeply (6)  max-depth

✖ 1 problem (0 errors, 1 warning)

cc @janvennemann

@acaland
Copy link

acaland commented Sep 27, 2019

It seems that this receipt does not work with the 28.0.0.

I am trying to build a module that uses a third party library that depends on Android Support Library 28.0.0. It seems that the current TiSDK 8.2.0.GA comes with 27.1.1. I am trying to bundle all the Android Support Library 28.0.0 into my module as described in the documentation but I am experiencing resource conflicts with the .aar appcompat-v7:28.0.0 depend on:

[ERROR] An error occurred during build after 6s 703ms [ERROR] Conflicting Android Libraries with package name "android.support.graphics.drawable" detected: [ERROR] /Users/tcaland/projects/tinamirialmodules/2019/tinamirialfeagui/android/lib/animated-vector-drawable-28.0.0.aar (hash: e2d41c2a032145313f42ab38a2d9757c5d1ebc19, origin: Module) [ERROR] /Users/tcaland/projects/tinamirialmodules/2019/tinamirialfeagui/android/lib/support-vector-drawable-28.0.0.aar (hash: 80387886ef55af284d8253e52d321f93b3f923dd, origin: Module) [ERROR] [ERROR] Please either select a version of these modules where the conflicting .aar file is the same or you can try removing the .aar file from one module's "lib" folder.

Any other way to include 28.0.0 ?
I have also tried to install 8.3.x builds, but they still provide 27.1.1.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants