New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[TIMOB-24446] Allow replacing bundled Android Support Libraries #9008
Conversation
@janvennemann Please document this new feature in our wikis, so developer know how to replace libraries. Maybe even an own guide on how to do it and some background on what is done internally to select and merge the libraries. You can create a new TIDOC-ticket to handle that. |
@hansemannn i was planning on doing exactly that next. I will add a whole new section to the Android Module Development Guide explaining the .aar handling, including the Support Library override. |
Fixes an issue with Hyperloop 2.1.0 which causes a crash when trying to override the Android Support Libraries with local .aar files. Hyperloop 2.1.0 will always manually add our bundled Android Support Libraries to the dexer paths even if they were replaced by the builder. To fix this we check the altered dexer paths again and remove any replaced libraries.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
CR: PASS
👍
@garymathews i just updated this PR to also allow the design support libraries to be replaced because they are now part of our bundled support libraries as of #9027 |
Relates to #9258 |
I think this PR or one related causes linting issues:
|
It seems that this receipt does not work with the 28.0.0. I am trying to build a module that uses a third party library that depends on Android Support Library 28.0.0. It seems that the current TiSDK 8.2.0.GA comes with 27.1.1. I am trying to bundle all the Android Support Library 28.0.0 into my module as described in the documentation but I am experiencing resource conflicts with the .aar appcompat-v7:28.0.0 depend on:
Any other way to include 28.0.0 ? |
JIRA: https://jira.appcelerator.org/browse/TIMOB-24446
Optional Description:
This allows a user to replace our bundled Android Support Libraries with one of their own choosing, either from a module or from the project's
platform/android
folder.This relies on #8792 and #9027, so only merge after those two PRs.