Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[6_1_X][TIMOB-14742] Android: Fixed window/view "backgroundImage" assignment where it loads the same image 4 times. #9032

Closed
wants to merge 2 commits into from

Conversation

jquick-axway
Copy link
Contributor

JIRA: https://jira.appcelerator.org/browse/TIMOB-14742

This is a back-port of approved PR #8960.
It is needed by upcoming 6.1.x PRs related to image loading.

Note:
Titanium no longer prints each image it's loading to the Android log. So, QE is unable to verify that the image is loading just once or multiple times anymore. But please run the below test to verify that "backgroundImage" before still works for single image backgrounds and multi-state backgrounds.

Testing:

  1. Build and run "KitchenSink" app for Android.
  2. Tap "Button" item in the list.
  3. Tap the "CLICK ME" button several times to verify it changes state like before.
  4. Tap the "Back" button.
  5. Tap the "Buttons States" item in the list.
  6. Tap the "CLICK ME" button several times to verify it changes state like before.

Copy link
Contributor

@longton95 longton95 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FR passed.

Tested using the test case above, the test case performs as expected and works as before.

ENV

SDK Version : Local 6.2.0, 6.1.0
Mac OS Version : 10.12.4
Appc CLI : 6.2.1
Appc NPM : 4.2.9
Node : v4.6.0
Device: Nexus 5x(6.0.1) Pixel XL(7.1.2)
Emulator: (6.0), (4.4.2)

@hansemannn hansemannn added this to the 6.1.0 milestone May 22, 2017
@hansemannn
Copy link
Collaborator

Moving out of 6.1.0, will do it in 6.2.0 to have more space to test.

@hansemannn hansemannn closed this May 22, 2017
@hansemannn hansemannn removed this from the 6.1.0 milestone May 22, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants