Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TIMOB-14742] Android: Fixed window/view "backgroundImage" assignment where it was loading the same image 4 times. #8960

Merged
merged 4 commits into from
May 22, 2017

Conversation

jquick-axway
Copy link
Contributor

@jquick-axway jquick-axway commented Apr 12, 2017

JIRA: https://jira.appcelerator.org/browse/TIMOB-14742

Note:
Titanium no longer prints each image it's loading to the Android log. So, QE is unable to verify that the image is loading just once or multiple times anymore. But please run the below test to verify that "backgroundImage" before still works for single image backgrounds and multi-state backgrounds.

Testing:

  1. Build and run "KitchenSink" app for Android.
  2. Tap "Button" item in the list.
  3. Tap the "CLICK ME" button several times to verify it changes state like before.
  4. Tap the "Back" button.
  5. Tap the "Buttons States" item in the list.
  6. Tap the "CLICK ME" button several times to verify it changes state like before.

@jquick-axway jquick-axway changed the title Android: Fixed window/view "backgroundImage" assignment where it was loading the same image 4 times. [TIMOB-14742] Android: Fixed window/view "backgroundImage" assignment where it was loading the same image 4 times. Apr 12, 2017
Copy link
Contributor

@garymathews garymathews left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CR: PASS
FT: PASS

👍

Copy link
Contributor

@longton95 longton95 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FR passed.

Tested using the test case above, the test case performs as expected and works as before.

ENV

SDK Version : Local 6.2.0, 6.1.0
Mac OS Version : 10.12.4
Appc CLI : 6.2.1
Appc NPM : 4.2.9
Node : v4.6.0
Device: Nexus 5x(6.0.1) Pixel XL(7.1.2)
Emulator: (6.0), (4.4.2)

@longton95 longton95 merged commit f4e21f0 into tidev:master May 22, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants