New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[TIMOB-1028] Android: Implement AudioRecorder (Parity) #9067
Conversation
Base functionality added.
Add canRecord property. Clean up code. Add comments.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please also change the docs to include the android
platform in the platforms:
key, where ever an API is available cross-platform now. Also add docs for the Android-only ones. Thank you!
Change two methods' names to match the update for iOS from 6.1.0. Change docs to include the added methods.
@hansemannn Changed the docs to include the new methods. Also renamed two of them (methods) to match the update from iOS. |
Fix the messed new method names.
Fixed the names. |
FR Passed. With proper permissions, the audio recorder's record, pause, play, stop works as expected.
Studio Ver: 4.9.1.201707200100 |
JIRA: https://jira.appcelerator.org/browse/TIMOB-1028
Description:
Base implementation of the AudioRecorder. In order to have play/pause functionality on API 22 and below and avoid formats that are not supported on some vendors' Android implementations currently it records uncompressed audio data in WAV format.
Basic test code:
Edit: Changed permissions methods' names in the test case to match the latest update.