[6_2_X][TIMOB-1028] Android: Implement AudioRecorder (Parity) #9268
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Base functionality added.
Add canRecord property. Clean up code. Add comments.
Change two methods' names to match the update for iOS from 6.1.0. Change docs to include the added methods.
Fix the messed new method names.
garymathews
reviewed
Aug 1, 2017
|
|
||
| @Kroll.method | ||
| public TiFileProxy stop() { | ||
| return new TiFileProxy(TiFileFactory.createTitaniumFile(tiAudioRecorder.stopRecording(),false)); |
garymathews
reviewed
Aug 1, 2017
| @Kroll.getProperty | ||
| public boolean getCanRecord() | ||
| { | ||
| return TiApplication.getInstance().getPackageManager().hasSystemFeature( "android.hardware.microphone"); |
There was a problem hiding this comment.
remove whitespace after (
garymathews
reviewed
Aug 1, 2017
|
|
||
| public TiAudioRecorder() { | ||
| //Get the minimum buffer size according to the device recording capabilities | ||
| bufferSize = AudioRecord.getMinBufferSize(RECORDER_SAMPLE_RATE,RECORDER_CHANNELS,RECORDER_AUDIO_ENCODING); |
garymathews
reviewed
Aug 1, 2017
|
|
||
| public void startRecording() { | ||
| try { | ||
| tempFileReference = TiFileHelper.getInstance().getTempFile(AUDIO_RECORDER_TEMP_FILE,true); |
garymathews
reviewed
Aug 1, 2017
| } | ||
|
|
||
| //Initialize the audio recorded with big enough buffer to ensure smooth reading from it without overlap | ||
| audioRecord = new AudioRecord(MediaRecorder.AudioSource.MIC,RECORDER_SAMPLE_RATE, RECORDER_CHANNELS,RECORDER_AUDIO_ENCODING, bufferSize*4); |
garymathews
reviewed
Aug 1, 2017
| audioRecord.release(); | ||
| audioRecord = null; | ||
| try { | ||
| resultFile = TiFileHelper.getInstance().getTempFile(AUDIO_RECORDER_FILE_EXT_WAV,true); |
garymathews
reviewed
Aug 1, 2017
| e.printStackTrace(); | ||
| } | ||
| } | ||
| return resultFile != null ? resultFile.getAbsolutePath():""; |
There was a problem hiding this comment.
space before and after :
garymathews
reviewed
Aug 1, 2017
| if (audioRecord != null) { | ||
| paused = false; | ||
| audioRecord.startRecording(); | ||
| audioRecord.read(audioData,0,bufferSize); |
garymathews
reviewed
Aug 1, 2017
| totalDataLen = totalAudioLen + 36; | ||
|
|
||
| //Write the WAV header | ||
| writeWaveFileHeader(out, totalAudioLen, totalDataLen,RECORDER_SAMPLE_RATE, channels, byteRate); |
garymathews
reviewed
Aug 1, 2017
| long longSampleRate, int channels, long byteRate) throws IOException { | ||
| byte[] header = new byte[44]; | ||
|
|
||
| header[0] = 'R'; // RIFF/WAVE header |
There was a problem hiding this comment.
could initialise the array with data instead?
byte[] header = {
'R', 'I', 'F'
...
};
garymathews
reviewed
Aug 1, 2017
| header[42] = (byte) ((totalAudioLen >> 16) & 0xff); | ||
| header[43] = (byte) ((totalAudioLen >> 24) & 0xff); | ||
|
|
||
| out.write(header, 0, 44); |
garymathews
reviewed
Aug 1, 2017
| @Override | ||
| public void onPeriodicNotification(AudioRecord recorder) { | ||
| try { | ||
| audioRecord.read(audioData,0,bufferSize); |
garymathews
suggested changes
Aug 1, 2017
|
FR Passed. With proper permissions, the audio recorder's record, pause, play, stop works as expected.
Studio Ver: 4.9.1.201707200100 |
|
Will merge when the requested changes are done. |
A more visual appealing container header initialisation.
|
@garymathews Updated. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JIRA: https://jira.appcelerator.org/browse/TIMOB-1028
Description:
Cherry pick of: #9067