Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[6_1_X][TIMOB-24737] Android: Fix Ti.UI.WebView.disableContextMenu getter #9093

Merged
merged 1 commit into from May 26, 2017

Conversation

garymathews
Copy link
Contributor

Copy link
Contributor

@jquick-axway jquick-axway left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CR: Pass

Copy link
Contributor

@ssjsamir ssjsamir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Master - #9092

FR Passed - WebView.disableContextMenu no longer crashes if it is never assigned

Test Steps

var win = Ti.UI.createWindow({layout: 'horizontal'}),
    wv = Ti.UI.createWebView({
        scalesPageToFit: true,
        height: Ti.UI.SIZE,
        url: 'http://bit.ly/2qrpV4L'
    }),
    btn = Ti.UI.createButton({
        title: 'GET disableContextMenu',
        width: '100%'
    });

btn.addEventListener('click', function() {
    alert('disableContextMenu: ' + wv.getDisableContextMenu());
});

win.add([btn, wv]);
win.open();
var window = Ti.UI.createWindow();
var webView = Ti.UI.createWebView(
{
	url: "https://appcelerator.com",
//	disableContextMenu: true,
});
window.add(webView);
window.open();
 
// Crashes when accessing "disableContextMenu" if property was never assigned.
Ti.API.info("- webView.disableContextMenu: " + webView.disableContextMenu.toString());
  • Application ran without any issues

Test environement
Appcelerator Command-Line Interface, version 6.2.2
Google Nexus 6P (7.1.2)
Operating System Name: Mac OS X El Capitan
Operating System Version: 10.11.6
Node.js Version: 4.6.0
npm: 4.2.8
Xcode: 8.2
Appcelerator Studio: 4.8.1.201612050850

@ssjsamir ssjsamir merged commit 8412335 into tidev:6_1_X May 26, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants