[TIMOB-24737] Android: Fix Ti.UI.WebView.disableContextMenu getter

[garymathews]

• Set default value for disableContextMenu
• Guard against null value in TiConvert.toBoolean

TEST CASE

var win = Ti.UI.createWindow({layout: 'horizontal'}),
    wv = Ti.UI.createWebView({
        scalesPageToFit: true,
        height: Ti.UI.SIZE,
        url: 'http://bit.ly/2qrpV4L'
    }),
    btn = Ti.UI.createButton({
        title: 'GET disableContextMenu',
        width: '100%'
    });

btn.addEventListener('click', function() {
    alert('disableContextMenu: ' + wv.getDisableContextMenu());
});

win.add([btn, wv]);
win.open();

JIRA Ticket

[jquick-axway]

CR: Pass

[jquick-axway]

CR: Pass

[ssjsamir]

FR Passed - WebView.disableContextMenu no longer crashes if it is never assigned

Test Steps

• Build a version of the SDK using this PR
• Created a titanium project using the SDK built from this PR
• Created an application with the following code from: [TIMOB-24737] Android: Fix Ti.UI.WebView.disableContextMenu getter #9092

var win = Ti.UI.createWindow({layout: 'horizontal'}),
    wv = Ti.UI.createWebView({
        scalesPageToFit: true,
        height: Ti.UI.SIZE,
        url: 'http://bit.ly/2qrpV4L'
    }),
    btn = Ti.UI.createButton({
        title: 'GET disableContextMenu',
        width: '100%'
    });

btn.addEventListener('click', function() {
    alert('disableContextMenu: ' + wv.getDisableContextMenu());
});

win.add([btn, wv]);
win.open();

• Ran the program
• Pressed Get DISABLECONTEXTMENU
• Alert dialog was shown without any errors
• I then created another application with the following code from: https://jira.appcelerator.org/browse/TIMOB-24737

var window = Ti.UI.createWindow();
var webView = Ti.UI.createWebView(
{
	url: "https://appcelerator.com",
//	disableContextMenu: true,
});
window.add(webView);
window.open();
 
// Crashes when accessing "disableContextMenu" if property was never assigned.
Ti.API.info("- webView.disableContextMenu: " + webView.disableContextMenu.toString());

• Application ran without any issues

Test environement
Appcelerator Command-Line Interface, version 6.2.2
Google Nexus 6P (7.1.2)
Operating System Name: Mac OS X El Capitan
Operating System Version: 10.11.6
Node.js Version: 6.10.1
npm: 4.2.8
Xcode: 8.2
Appcelerator Studio: 4.8.1.201612050850