Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[TIMOB-24963] iOS/Android: Add scrollToTop() to ScrollView #9221

Closed
wants to merge 729 commits into from
Closed

[TIMOB-24963] iOS/Android: Add scrollToTop() to ScrollView #9221

wants to merge 729 commits into from

Conversation

m1ga
Copy link
Contributor

@m1ga m1ga commented Jul 14, 2017 •
edited by hansemannn

@hansemannn hansemannn changed the title [AC-5088] Android: Add scrollToTop() to ScrollView [TIMOB-24963] iOS/Android: Add scrollToTop() to ScrollView Jul 16, 2017
hansemannn
hansemannn approved these changes Jul 16, 2017
View reviewed changes
Copy link
Collaborator

@hansemannn hansemannn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Will await the Android review as well.

@hansemannn hansemannn added the ios label Jul 18, 2017
@lokeshchdhry
Copy link
Contributor

@hansemannn , @garymathews, Is the android CR done for this ?

@hansemannn
Copy link
Collaborator

@lokeshchdhry Not, yet. Awaiting the CR from @garymathews, but iOS is approved.

@hansemannn hansemannn added this to the 7.0.0 milestone Aug 7, 2017
@hansemannn
Copy link
Collaborator

@m1ga As 6.2.0 is branched already and this is a minor feature, please change the since to 7.0.0, thx!

sgtcoolguy and others added 19 commits October 2, 2017 12:56
@sgtcoolguy
Revert "Update modules.json"
570a4e0 
This reverts commit ae83433.
Merge branch 'master' into TIMOB-25238
46e499c
Merge pull request tidev#9410 from garymathews/TIMOB-25238
7608954 
[TIMOB-25238] Android: Refactor TiBorderWrapperView to improve performance
[TIMOB-25359] Fix Ti.UI.ScrollView when keyboard is active
f952721
Merge branch 'master' into TIMOB-25266
9c1f181
Merge pull request tidev#9432 from garymathews/TIMOB-25266
9f6d86d 
[TIMOB-25266] Android: Fix WebView HW-acceleration for Android 4.1
@garymathews
Merge branch 'master' into TIMOB-25051
c99a971
[TIMOB-25359] Missing imports
48437bd
@garymathews
Merge branch 'master' into TIMOB-25359
9035c56
@sgtcoolguy
No longer upload NSP results to Threadfix, the server seems to random…
c1ceb22 
…ly stop accepting NSP uploads and cause build failures for us mysteriously.
Merge branch 'master' into TIMOB-25359
f1e6aa7
@vijaysingh-axway
[TIMOB-25301]: iPhone X Need to be able to control the Insets / Layou…
378c5c1 
…t Margins
Merge pull request tidev#9502 from garymathews/TIMOB-25359
bd58489 
[TIMOB-25359] Android: Fix Ti.UI.ScrollView when keyboard is active
@vijaysingh-axway
[TIMOB-25301]: window property passed to safeAreaView
5d17368
@vijaysingh-axway
[TIMOB-25301]: Safe area layout calculated early
8aa4c49
@gimdongwoo
add description, validation
78eb6ef
@gimdongwoo
Merge branch 'master' into sigalg
7e6428c
@gimdongwoo
add default value for sigalg
f4078f2
@gimdongwoo
change indent
ca50a8b
hansemannn and others added 20 commits November 13, 2017 15:59
@hansemannn @sgtcoolguy
[TIMOB-25504] Fix default-image selection
5c9dbe5
@ypbnv @sgtcoolguy
Fix window flags for extendBackground.
fc17b0a
@ypbnv @sgtcoolguy
Let the system take care of status bar's height compensation.
fd9f4d5
@feons @sgtcoolguy
[CLI-649] direct users to use appc ti config if run from appc
f793b7b
@ewanharris @sgtcoolguy
[TIMOB-25216] Include Windows Modules docs
c743348
@ewanharris @sgtcoolguy
[TIMOB-25202] Update to windowlib@0.6.0
c2a7d76
Merge pull request tidev#9265 from garymathews/TIMOB-10724
2984305 
[TIMOB-10724] Android: Remove native module gperf dependency
@mukherjee2
Merge pull request tidev#9563 from feons/TIMOB-24000
e08975b 
[TIMOB-24000] Module build should error if the apiversion in manifest…
@eric34
Merge pull request tidev#8953 from hansemannn/TIMOB-10787
17fa7e2 
[TIMOB-10787] iOS: Expose modern UUID-replacements
@mukherjee2
Merge pull request tidev#9570 from ypbnv/TIMOB-25456
1a17630 
[TIMOB-25456] Android: Crash after calling JSON.stringify on Ti.UI.Window
@jquick-axway
Android: Lowered min "targetSdkVersion" from 25 to 23.
b346099
Merge pull request tidev#9595 from jquick-axway/TIMOB-25510
bf30ea3 
Android: Lowered min "targetSdkVersion" from 25 to 23.
@eric34
Merge pull request tidev#9576 from garymathews/TIMOB-25462
43395bb 
[TIMOB-25462] Android: Implement Ti.UI.WebView.userAgent
@eric34
Merge pull request tidev#9476 from maggieaxway/TIMOB-18500
1cc2aa1 
[TIMOB-18500] Android: event.cancel not set properly for optionsDialog
@eric34
Merge pull request tidev#9510 from ypbnv/TIMOB-25374
d82c621 
[TIMOB-25374] Android: borderColor not visible on Android tiSDK 6.2.2
@eric34
Merge pull request tidev#9564 from garymathews/TIMOB-17340
2d80ff0 
[TIMOB-17340] Android: Implement Ti.UI.ATTRIBUTE_BASELINE_OFFSET
@eric34
Merge pull request tidev#9239 from hansemannn/TIMOB-25005
776fa27 
[TIMOB-25005] Remove Ti.UI.iPhone namespace
@eric34
Merge pull request tidev#9565 from garymathews/TIMOB-24679
1587545 
[TIMOB-24679] Android: Remove invalid constant definitions
@eric34
Merge pull request tidev#9276 from drauggres/TIMOB-25051
69b548f 
[TIMOB-25051] fix persistentObjects leak
@eric34
Merge pull request tidev#9475 from vijaysingh-axway/TIMOB-25301
4ce7c86 
[TIMOB-25301]:iPhone X: Need to be able to control the Insets / Layout Margins
jquick-axway
jquick-axway suggested changes Nov 14, 2017
View reviewed changes
android/modules/ui/src/java/ti/modules/titanium/ui/widget/TiUIScrollView.java Outdated
@@ -676,6 +676,18 @@ public void scrollToBottom()
}
}

public void scrollToTop()
{
View view = getNativeView();
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Once we update this PR with what's on master, we'll need to change this line of code...

View view = getNativeView();

...to...

View view = this.scrollView;

This is because we've added RefreshControl support to scroll views as of 6.3.0 and the getNativeView() method will return a SwipeRefreshLayout object instead.

@m1ga
Copy link
Contributor Author

m1ga commented Nov 14, 2017 •
edited

@jquick-axway you already changed the getNativeView(), right?

@jquick-axway
Copy link
Contributor

you already changed the getNativeView(), right?

@m1ga, I have. The goal was to get this PR into 7.0.0 since the Windows PR has already been merged in. But when I resolved the conflicts, this PR is now showing the entire commit history of the merge. Hmm...

@jquick-axway jquick-axway mentioned this pull request Nov 15, 2017
Merged
@jquick-axway
Copy link
Contributor

@m1ga, since I screwed up the commit history for this PR, I've set up a new PR #9601 to replace this one. Your commit changes are still intact and credit was given where credit was due.

I've also discovered that animated scrolling in a vertical ScrollView via scrollTo() and your new scrollToTop() method no longer worked on Android as of Titanium 6.2.2. This is due to us using Google's NestedScrollView in place of the ScrollView Java class. It appears to be a bug in the NestedScrollView class. The new PR resolves this issue by disabling animated scrolling in this case (kind of a bummer, but haven't found a better work-around).

@jquick-axway
Copy link
Contributor

Closing in favor of PR #9601.

@m1ga m1ga deleted the scrollToTop branch March 29, 2018 19:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jquick-axway jquick-axway jquick-axway requested changes

@hansemannn hansemannn hansemannn approved these changes

@garymathews garymathews Awaiting requested review from garymathews

Assignees
No one assigned
Labels
android community 🔥 feature ios
Projects
None yet
Milestone
7.0.0
Development

Successfully merging this pull request may close these issues.

None yet