[TIMOB-10787] iOS: Expose modern UUID-replacements #8953
Conversation
iphone/Classes/PlatformModule.m
Outdated
| #if defined(USE_TI_PLATFORMIDENTIFIERFORADVERTISING) || defined(USE_TI_PLATFORMGETIDENTIFIERFORADVERTISING) | ||
| - (NSString *)identifierForAdvertising | ||
| { | ||
| return [[[ASIdentifierManager sharedManager] advertisingIdentifier] UUIDString]; |
There was a problem hiding this comment.
Apple here suggest, we should use this by checking isAdvertisingTrackingEnabled. We can expose "isAdvertisingTrackingEnabled" property as well . Ygor Lemos has also suggested the same in comment.
There was a problem hiding this comment.
Good idea, added it!
iphone/Classes/PlatformModule.m
Outdated
| } | ||
|
|
||
| #if defined(USE_TI_PLATFORMIDENTIFIERFORADVERTISING) || defined(USE_TI_PLATFORMGETIDENTIFIERFORADVERTISING) | ||
| - (NSNumber *)isAdvertisingTrackingEnabled |
There was a problem hiding this comment.
Make "isAdvertisingTrackingEnabled" property in .h file similar to
+@Property(readonly,nonatomic) NSString *identifierForAdvertising;
|
@hansemannn Can you resolve conflicts please. |
… TIMOB-10787 # Conflicts: # apidoc/Titanium/Platform/Platform.yml # iphone/Classes/PlatformModule.h # iphone/Classes/PlatformModule.m # iphone/Classes/defines.h
|
@vijaysingh-axway Restored and added unit-tests |
|
FR Passed. IdentifierForVendor and IdentifierForAdvertising return the appropriate values. Tested on multiple sims/devices with different apps and with advertising tracking enabled and disabled. |
JIRA: https://jira.appcelerator.org/browse/TIMOB-10787