[TIMOB-25004] Updated ioslib to 1.4.9. #9252
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ewanharris
approved these changes
Jul 26, 2017
There was a problem hiding this comment.
CR/FR Pass!
Pruning the dependencies no longer removes ioslib from the checked in node_modules directory, built SDK works as expected,
Only nit is that I just noticed that node-titanium-sdk is not at a fixed version not sure whether that should be changed?
Other than that LGTM! Thanks for taking it over :)
(Holding off merge as not sure whether this needs to go into in-qe-testing)
|
I wouldn't worry about node-titanium-sdk. I don't think we need to wait for QE testing since master has 1.4.9 and it's been working. |
|
Grand, I'll go ahead and merge then |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JIRA: https://jira.appcelerator.org/browse/TIMOB-25004