[TIMOB-25004][6_1_X] - Update ioslib to 1.4.9 #9229
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ewanharris
changed the title
ewanharris
force-pushed
the
update_ioslib
branch
from
9287b22
to
dcb08c8
Compare
|
Replaced by #9252 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://jira.appcelerator.org/browse/TIMOB-25004
It looks like we went from ioslib@1.4.8-> ioslib@1.4.7 on 6_1_X, this PR corrects that and updates to iosli@1.4.9, it didn't appear to have any code changes so I deemed it safe to go to 1.4.9 over 1.4.8
I believe this is the cause of the 'Cannot find ioslib' failures we have been seeing on Jenkins as when running
npm prune --productionnpm would remove ioslib as the package.json states^1.4.8but the installed package was 1.4.7 which is invalid for the stated range, if the downgrade of the package was intentional we need to edit the package.json to reflect thisThis PR does not need to be cherrypicked to any other branch