[TIMOB-24987] Android: Setting a custom theme's parent to "Theme.Titanium" no longer causes a recursive lookup. #9255
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nium" no longer causes a recursive lookup. - Modified "Theme.Titanium" to no longer use the AndroidManifest.xml <application> tag's theme as its parent. * This was the cause of the recursion if the custom theme was applied to the application. * Fixed by reverting PR tidev#8592 (ie: TIMOB-19629). - Also fixed ListView to correctly apply its activity's theme to its rows, headers, and footers. * This addresses the bug for PR tidev#8592 that I reverted.
|
FR Passed. For TIMOB-19629 - the buttons are lower cased & the labels have the color green as expected. Verified it with an alloy app with a textField & custom theme. The keyboard did pop up as expected when tapped on the textField. Studio Ver: 4.9.1.201707200100 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JIRA: https://jira.appcelerator.org/browse/TIMOB-24987
Cherry Pick of Pull Request: #9253