[TIMOB-25046] iOS: Fix peek-and-pop and other analyser warnings #9289
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vijaysingh-axway
approved these changes
Aug 14, 2017
|
@hansemannn There are some conflicts reported below, can you please resolve? |
|
@mukherjee2 Done! |
mukherjee2
approved these changes
Aug 15, 2017
There was a problem hiding this comment.
Environment:
Node Version: 6.10.3
NPM Version: 3.10.10
Mac OS: 10.12.4
Appc CLI: 6.2.3
Appc CLI NPM: 4.2.9
Titanium SDK version: 6.2.0.v20170815112142
Appcelerator Studio, build: 4.9.1.201707200100
Xcode 8.3.2
Passed FR. I first checked with 6.0.3.GA and verified that the 3D touch worked as expected. Then I reproduced the bug in 6.1.2.GA. Finally, I checked with the SDK version built on this PR, and validated that the fix works.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JIRA: https://jira.appcelerator.org/browse/TIMOB-25046