Merge pull request #9289 from hansemannn/TIMOB-25046

[TIMOB-25046] iOS: Fix peek-and-pop and other analyser warnings
tidev · Aug 15, 2017 · 63b4cb1 · 63b4cb1
2 parents 2e3b11d + 0fed7ee
commit 63b4cb1
Show file tree

Hide file tree

Showing 4 changed files with 5 additions and 12 deletions.
diff --git a/iphone/Classes/TiMediaMusicPlayer.m b/iphone/Classes/TiMediaMusicPlayer.m
@@ -88,7 +88,7 @@ - (NSArray *)itemsFromArg:(id)args
                  subreason:nil
                   location:CODELOCATION];
 
-      return;
+      return items;
     }
 
     [items addObject:[query.items firstObject]];

diff --git a/iphone/Classes/TiUIOptionDialogProxy.m b/iphone/Classes/TiUIOptionDialogProxy.m
@@ -149,21 +149,14 @@ - (void)hide:(id)args
     return;
   }
 
-  id options = nil;
-  if ([args count] > 0) {
-    options = [args objectAtIndex:0];
-  }
-  BOOL animatedhide = [TiUtils boolValue:@"animated" properties:options def:YES];
-
   TiThreadPerformOnMainThread(^{
     if (alertController != nil) {
       [alertController dismissViewControllerAnimated:animated
                                           completion:^{
                                             [self cleanup];
                                           }];
     }
-  },
-      NO);
+  }, NO);
 }
 
 - (void)suspended:(NSNotification *)note

diff --git a/iphone/Classes/TiUIiOSPreviewActionProxy.m b/iphone/Classes/TiUIiOSPreviewActionProxy.m
@@ -35,13 +35,13 @@ - (NSString *)apiName
 - (UIPreviewAction *)action
 {
   if (action == nil) {
-    action = [UIPreviewAction actionWithTitle:_title
+    action = [[UIPreviewAction actionWithTitle:_title
                                         style:_style
                                       handler:^void(UIPreviewAction *_action, UIViewController *_controller) {
                                         if ([self _hasListeners:@"click"]) {
                                           [self fireEventWithAction:_action];
                                         }
-                                      }];
+                                      }] retain];
   }
 
   return action;

diff --git a/iphone/Classes/TiUIiOSPreviewContextProxy.m b/iphone/Classes/TiUIiOSPreviewContextProxy.m
@@ -84,7 +84,7 @@ - (void)connectToDelegate
   }
 
   UIViewController *controller = [[[TiApp app] controller] topPresentedController];
-  [controller registerForPreviewingWithDelegate:[[[TiPreviewingDelegate alloc] initWithPreviewContext:self] autorelease]
+  [controller registerForPreviewingWithDelegate:[[TiPreviewingDelegate alloc] initWithPreviewContext:self]
                                      sourceView:nativeSourceView];
 }