New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[6_2_X][TIMOB-24802] apidoc: Mark ListViewAnimationProperties supported on Windows #9405
Conversation
@@ -1715,7 +1715,7 @@ properties: | |||
- name: position | |||
summary: Specifies what position to scroll the selected cell to. | |||
type: Number | |||
constants: Titanium.UI.iOS.ListViewScrollPosition.* | |||
constants: [Titanium.UI.iOS.ListViewScrollPosition.*, Titanium.UI.Windows.ListViewScrollPosition.*] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should move it to Ti.UI if at least 2 platforms support it
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think that's a very good point. I would define new constants under Ti.UI.Windows
in this case because they may have a same name (such as TOP), but they act differently.
I would think that if we can define same behavior across platforms for the constant, we should move it to Ti.UI
namespace. But that was not the case for ListViewScrollPosition for now.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@infosia Feel free to re-run Jenkines once the Windows PR is merged. Right now, it will fail:
|
Looks like the yaml docs that I added to |
@infosia I think you cannot use any |
JIRA: https://jira.appcelerator.org/browse/TIMOB-24802
Ti.UI.ListView
supportsTi.UI.ListViewAnimationProperties
on Windows as of 6.2.0.RC.This requires https://github.com/appcelerator/titanium_mobile_windows/pull/1095 to be merged too.