Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[6_2_X][TIMOB-24802] apidoc: Mark ListViewAnimationProperties supported on Windows #9405

Closed
wants to merge 3 commits into from

Conversation

infosia
Copy link
Contributor

@infosia infosia commented Sep 6, 2017

JIRA: https://jira.appcelerator.org/browse/TIMOB-24802

Ti.UI.ListView supports Ti.UI.ListViewAnimationProperties on Windows as of 6.2.0.RC.

This requires https://github.com/appcelerator/titanium_mobile_windows/pull/1095 to be merged too.

@@ -1715,7 +1715,7 @@ properties:
- name: position
summary: Specifies what position to scroll the selected cell to.
type: Number
constants: Titanium.UI.iOS.ListViewScrollPosition.*
constants: [Titanium.UI.iOS.ListViewScrollPosition.*, Titanium.UI.Windows.ListViewScrollPosition.*]
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should move it to Ti.UI if at least 2 platforms support it

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think that's a very good point. I would define new constants under Ti.UI.Windows in this case because they may have a same name (such as TOP), but they act differently.

I would think that if we can define same behavior across platforms for the constant, we should move it to Ti.UI namespace. But that was not the case for ListViewScrollPosition for now.

Copy link
Contributor

@garymathews garymathews left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hansemannn
Copy link
Collaborator

@infosia Feel free to re-run Jenkines once the Windows PR is merged. Right now, it will fail:

ListViewAnimationProperties: found 1 error(s)!
	properties
		position
			constants
				Invalid constant: Titanium.UI.Windows.ListViewScrollPosition.*

@infosia
Copy link
Contributor Author

infosia commented Sep 7, 2017

Looks like the yaml docs that I added to titanium_mobile_windows is not applied yet. @garymathews Do you know how to push updates on titanium_mobile_windows/apidoc/WindowsOnly? It's https://github.com/appcelerator/titanium_mobile_windows/pull/1094 in particular.

@hansemannn
Copy link
Collaborator

@infosia I think you cannot use any Titanium.UI.Windows references in this repo, it has to be merged from titanium_mobile_windows. Because of that, the fact that we always generate our web-docs from master, we release 6.2.0 today and I need to branch 6_3_X, I will close this PR. Please let me know if it should be reopened or re-created for 6.3.0.

@hansemannn hansemannn closed this Sep 13, 2017
@hansemannn hansemannn removed this from the 6.2.0 milestone Sep 13, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants