Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[6_2_X][TIMOB-24802] apidoc: Mark ListViewAnimationProperties supported on Windows #9405

Closed
wants to merge 3 commits into from
Closed

[6_2_X][TIMOB-24802] apidoc: Mark ListViewAnimationProperties supported on Windows #9405

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
a8527af
Mark ListViewAnimationProperties supported on Windows
infosia Sep 6, 2017
9a7205b
Merge branch '6_2_X' into TIMOB-24802_doc_6_2_X
garymathews Sep 7, 2017
eb57f0d
Merge branch '6_2_X' into TIMOB-24802_doc_6_2_X
hansemannn Sep 8, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
4 changes: 2 additions & 2 deletions apidoc/Titanium/UI/ListView.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1135,7 +1135,7 @@ methods:
type: Number

- name: animation
summary: Animation properties. (iOS and Android only.)
summary: Animation properties. (iOS, Android and Windows)
type: ListViewAnimationProperties
optional: true

Expand Down Expand Up @@ -1715,7 +1715,7 @@ properties:
- name: position
summary: Specifies what position to scroll the selected cell to.
type: Number
constants: Titanium.UI.iOS.ListViewScrollPosition.*
constants: [Titanium.UI.iOS.ListViewScrollPosition.*, Titanium.UI.Windows.ListViewScrollPosition.*]
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should move it to Ti.UI if at least 2 platforms support it

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think that's a very good point. I would define new constants under Ti.UI.Windows in this case because they may have a same name (such as TOP), but they act differently.

I would think that if we can define same behavior across platforms for the constant, we should move it to Ti.UI namespace. But that was not the case for ListViewScrollPosition for now.

default: Titanium.UI.iOS.ListViewScrollPosition.NONE

---
Expand Down