New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[TIMOB-25238] Android: Refactor TiBorderWrapperView to improve performance #9410
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me!
I'd like to make a suggestion. (Note that this suggestion does not block this PR.) It would be nice if our As it is now, a border view will always be applied to a view, even if these properties are initialized to zero (like how it is with WebView). So, not only will this get rid of the extra canvas draws/clipping in TiBorderWrapperView that'll do nothing, it'll also help prevent hardware acceleration from being disabled when it doesn't need to be. |
ad7cc71
to
8ca7329
Compare
FR Passed. For the first test - UI does not show any lag & for the second test -- Rectangle shows border and elevation & circle has a border with no aliasing. Studio Ver: 4.10.0.201709271713 |
Generated by 🚫 dangerJS |
TiBorderWrapperView
to improve performance ofTitanium.UI.View
withborderColor
definedTEST CASE #1
TEST CASE #2
JIRA Ticket