Skip to content

Commit

Permalink
Merge branch 'master' into TIMOB-25238
Browse files Browse the repository at this point in the history
  • Loading branch information
ypbnv committed Sep 8, 2017
2 parents 5cbb8e4 + e270e0d commit ad7cc71
Show file tree
Hide file tree
Showing 4 changed files with 13 additions and 15 deletions.
4 changes: 2 additions & 2 deletions Jenkinsfile
Original file line number Diff line number Diff line change
Expand Up @@ -115,8 +115,8 @@ timestamps {
nodejs(nodeJSInstallationName: "node ${nodeVersion}") {

stage('Lint') {
// Enforce npm 5.2.0 right now, since 5.3.0 has a bug in pruning to production: https://github.com/npm/npm/issues/17781
sh 'npm install -g npm@5.2'
// NPM 5.2.0 had a bug taht broke pruning to production, but latest npm 5.4.1 works well
sh 'npm install -g npm@5.4.1'

// Install dependencies
timeout(5) {
Expand Down
6 changes: 2 additions & 4 deletions iphone/cli/hooks/frameworks.js
Original file line number Diff line number Diff line change
Expand Up @@ -768,12 +768,10 @@ class FrameworkInspector {
}

let type;
if (stdout.indexOf('current ar archive') !== -1) {
type = FRAMEWORK_TYPE_STATIC;
} else if (stdout.indexOf('dynamically linked shared library') !== -1) {
if (stdout.indexOf('dynamically linked shared library') !== -1) {
type = FRAMEWORK_TYPE_DYNAMIC;
} else {
return reject(new Error('Unknown framework type:\n' + stdout));
type = FRAMEWORK_TYPE_STATIC;
}

resolve({
Expand Down
16 changes: 8 additions & 8 deletions package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,7 @@
"request": "2.81.0",
"sprintf": "0.1.5",
"temp": "0.8.3",
"windowslib": "0.5.4",
"windowslib": "0.5.5",
"wrench": "1.5.9",
"xcode": "0.9.2",
"xmldom": "0.1.22"
Expand Down

0 comments on commit ad7cc71

Please sign in to comment.