[TIMOB-25269] (6_3_X) Support iPhone X launch-screens #9427
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # iphone/Classes/TiRootViewController.m # iphone/Classes/TiUtils.m
# Conflicts: # iphone/Classes/TiRootViewController.m # iphone/Classes/TiUtils.m
rborn
reviewed
Sep 18, 2017
| image = [UIImage imageNamed:@"LaunchImage-1100-Portrait-2436h@3x"]; | ||
| } else if (UIDeviceOrientationIsLandscape(orientation)) { | ||
| // Landscape | ||
| image = [UIImage imageNamed:@"LaunchImage-1100-2436h@3x"]; |
There was a problem hiding this comment.
Hi @hansemannn , any reason for the image not to have landscape in name? Thnx!
There was a problem hiding this comment.
Indeed. Xcode seems to store it as LaunchImage-1100-2436@3x.png inside the bundle, see this image from my post at StackOverflow:
There was a problem hiding this comment.
Which is incorrect, but it seems the way Xcode does it. I opened a radar already and awaiting feedback from Apple today.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JIRA: https://jira.appcelerator.org/browse/TIMOB-25269
Backport of #9423