-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[TIMOB-25269] (6_3_X) Support iPhone X launch-screens #9427
Conversation
# Conflicts: # iphone/Classes/TiRootViewController.m # iphone/Classes/TiUtils.m
# Conflicts: # iphone/Classes/TiRootViewController.m # iphone/Classes/TiUtils.m
image = [UIImage imageNamed:@"LaunchImage-1100-Portrait-2436h@3x"]; | ||
} else if (UIDeviceOrientationIsLandscape(orientation)) { | ||
// Landscape | ||
image = [UIImage imageNamed:@"LaunchImage-1100-2436h@3x"]; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @hansemannn , any reason for the image not to have landscape
in name? Thnx!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Indeed. Xcode seems to store it as LaunchImage-1100-2436@3x.png
inside the bundle, see this image from my post at StackOverflow:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Which is incorrect, but it seems the way Xcode does it. I opened a radar already and awaiting feedback from Apple today.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! APPROVED
JIRA: https://jira.appcelerator.org/browse/TIMOB-25269
Backport of #9423