Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TIMOB-24805] iOS: Don't require large window-titles value to be set #9541

Merged
merged 12 commits into from Nov 14, 2017

Conversation

hansemannn
Copy link
Collaborator

@hansemannn hansemannn commented Oct 20, 2017

Copy link
Contributor

@ssjsamir ssjsamir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FR Passed: No error log was shown.

Test Steps:

  • Created a new titanium project
  • Added the following code in to the project
var win = Ti.UI.createWindow( {
backgroundColor : 'white'
});
 
var btn = Ti.UI.createButton({
title: 'Trigger'
});
 
btn.addEventListener('click', openWindow);
win.add(btn);
 
var nav = Ti.UI.iOS.createNavigationWindow({
window: win
});
 
nav.open();
 
function openWindow() {
var win = Ti.UI.createWindow( {
backgroundColor : 'white'
} );
 
nav.openWindow(win);
}
  • Ran the application from studio
  • No error was shown in Studio

Test Environment
Appcelerator Command-Line Interface, Version 6.3.0-master.15
iPhone 7 emulator (11.0)
iphone 5S plus 11.0.3
Operating System Name: Mac OS High Sierra
Operating System Version: 10.13
Node.js Version: 6.10.1
Xcode: 9.0
Appcelerator Studio: 4.10.0.201709271713

@build build added the ios label Nov 3, 2017
@mukherjee2
Copy link
Contributor

@hansemannn can you please resolve conflicts and merge?

should(win.custom).be.eql(1234);
});

it.ios('largeTitleEnabled', function () {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FYI To make things easier for merging in new tests, you can now just add a tests/Resources/ti.ui.window.addontest.js with just the new tests and it'll get auto-picked up (and I don't have to wade through what changed between this overriding file and the original.).

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is awesome news Chris, thanks! 🙂

@sgtcoolguy sgtcoolguy merged commit 380cd96 into tidev:master Nov 14, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants