Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[TIMOB-24805] iOS: Don't require large window-titles value to be set #9541

Merged
merged 12 commits into from
Nov 14, 2017
Merged

[TIMOB-24805] iOS: Don't require large window-titles value to be set #9541

Show file tree
Hide file tree
Changes from 5 commits
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
f4b0653
[TIMOB-24805] Don't require value
hansemannn Oct 20, 2017
74db0a7
[TIMOB-24805] Add unit-tests
hansemannn Oct 20, 2017
05fdcde
[TIMOB-24805] Fix typo
hansemannn Oct 20, 2017
5d20588
Update ti.ui.window.test.js
hansemannn Oct 21, 2017
61e2fb9
Merge branch 'master' into TIMOB-24805-NEW
ssjsamir Oct 26, 2017
6bee4d6
Update ti.ui.window.test.js
hansemannn Oct 27, 2017
d8ca57c
Merge branch 'master' into TIMOB-24805-NEW
ssjsamir Oct 30, 2017
966eab9
Merge branch 'master' into TIMOB-24805-NEW
mukherjee2 Nov 3, 2017
a1d7d83
Merge branch 'master' into TIMOB-24805-NEW
mukherjee2 Nov 6, 2017
aafa899
Merge branch 'master' into TIMOB-24805-NEW
mukherjee2 Nov 7, 2017
5b1510b
Merge branch 'master' into TIMOB-24805-NEW
mukherjee2 Nov 10, 2017
93e4abe
Merge branch 'master' into TIMOB-24805-NEW
mukherjee2 Nov 10, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
4 changes: 2 additions & 2 deletions iphone/Classes/TiUIWindowProxy.m
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -809,7 +809,7 @@ - (void)setTitle:(NSString *)title_
- (void)setLargeTitleEnabled:(id)value
{
ENSURE_UI_THREAD(setLargeTitleEnabled, value);
ENSURE_TYPE(value, NSNumber);
ENSURE_TYPE_OR_NIL(value, NSNumber);

[self replaceValue:value forKey:@"largeTitleEnabled" notification:NO];

Expand All @@ -821,7 +821,7 @@ - (void)setLargeTitleEnabled:(id)value
- (void)setLargeTitleDisplayMode:(id)value
{
ENSURE_UI_THREAD(setLargeTitleDisplayMode, value);
ENSURE_TYPE(value, NSNumber);
ENSURE_TYPE_OR_NIL(value, NSNumber);

[self replaceValue:value forKey:@"largeTitleDisplayMode" notification:NO];

Expand Down