[TIMOB-25059] Add Hyperloop as a pre-packged module #9578
Conversation
First step of integrating Hyperloop into our SDK by bundling it as a pre-packaged module.
|
|
||
| // Hyperloop has no single platform downloads yet, so we use a fake platform | ||
| // that will download the all-in-one distribution. | ||
| supportedPlatforms = supportedPlatforms.concat([ 'hyperloop' ]); |
There was a problem hiding this comment.
so you can just hijack the "commonjs" entry to mean "All platforms" too. That's what I did locally when I took a look at this.
|
LGTM 👍 |
support/module/packaged/modules.json
Outdated
| @@ -15,5 +15,8 @@ | |||
| ], | |||
| "commonjs": [ | |||
| "https://github.com/appcelerator-modules/ti.cloud/releases/download/3.2.11/ti.cloud-commonjs-3.2.11.zip" | |||
| ], | |||
| "hyperloop": [ | |||
| "https://appcelerator-modules.s3.amazonaws.com/hyperloop-2.2.2.zip" | |||
There was a problem hiding this comment.
Please change to 3.0.0. Eventually, we should create a hyperloop-releases repo to store those, which would also have the benefit to attach changelogs and beta-versions.
There was a problem hiding this comment.
We probably should do that right away. I can't update this link right now because that would break builds since ee don't have a 3.0.0 published yet. That would also trigger the automatic update in SDKs <= 6.3.0 so we shouldn't even publish Hyperloop 3.0.0 the old way?
There was a problem hiding this comment.
Maybe we should. Then people with an old SDK can still download it, but that on the other hand still breaks their app because of the bumped api-version that requires 7.0.0 anyway.
|
PR approved. We should merge this one and do another PR once Hyperloop 3.0.0 GA is ready. |
JIRA: https://jira.appcelerator.org/browse/TIMOB-25059
Optional Description:
First step of integrating Hyperloop into our SDK by bundling it as a pre-packaged module.