-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[TIMOB-25059] Add Hyperloop as a pre-packged module #9578
Changes from 2 commits
8ab3e43
9322b90
801d083
46e2708
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -15,5 +15,8 @@ | |
], | ||
"commonjs": [ | ||
"https://github.com/appcelerator-modules/ti.cloud/releases/download/3.2.11/ti.cloud-commonjs-3.2.11.zip" | ||
], | ||
"hyperloop": [ | ||
"https://appcelerator-modules.s3.amazonaws.com/hyperloop-2.2.2.zip" | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Please change to 3.0.0. Eventually, we should create a There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. We probably should do that right away. I can't update this link right now because that would break builds since ee don't have a 3.0.0 published yet. That would also trigger the automatic update in SDKs <= 6.3.0 so we shouldn't even publish Hyperloop 3.0.0 the old way? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Maybe we should. Then people with an old SDK can still download it, but that on the other hand still breaks their app because of the bumped api-version that requires 7.0.0 anyway. |
||
] | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
so you can just hijack the "commonjs" entry to mean "All platforms" too. That's what I did locally when I took a look at this.