[TIMOB-19040] :Replace MPMoviePlayerController in Ti.Media.VideoPlayer with AVPlayerViewController #9600
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…Media.VideoPlayer with AVPlayerViewController"" This reverts commit c949974.
hansemannn
reviewed
Nov 15, 2017
| default: true | ||
| osver: | ||
| ios: | ||
| max: "9.0" |
There was a problem hiding this comment.
I am wondering how this passes linting. Some notes:
- It should be "min", not "max", because it was introduced in iOS 9
- The syntax is
osver: {ios: {min: "9.0"}} - Add a
.afterplayback
hansemannn
reviewed
Nov 15, 2017
| summary: The playback type of the movie. | ||
| deprecated: | ||
| since: "7.0.0" | ||
| notes: This method has been removed in Titanium SDK 7.0.0 as of the official deprecation by Apple. |
There was a problem hiding this comment.
Add: The source type is detected automatically in the newer Apple API's used. Full:
notes: |
This method has been removed in Titanium SDK 7.0.0 as of the official deprecation by Apple.
The source type is detected automatically in the newer Apple API's used.
hansemannn
approved these changes
Nov 15, 2017
|
FR Passed. Videos and video settings work as expected. Tested using the provided case as well as several other test apps with videos. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://jira.appcelerator.org/browse/TIMOB-19040