-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[TIMOB-19040] :Replace MPMoviePlayerController in Ti.Media.VideoPlayer with AVPlayerViewController #9600
Merged
Merged
[TIMOB-19040] :Replace MPMoviePlayerController in Ti.Media.VideoPlayer with AVPlayerViewController #9600
Changes from 2 commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
a999137
Revert "Revert "[TIMOB-19040] :Replace MPMoviePlayerController in Ti.…
vijaysingh-axway 4a1dc92
Merge branch 'master' into Timob_19040
vijaysingh-axway 4ec2554
[TIMOB-19040] : Support for repeat mode
vijaysingh-axway 1eba0a7
Merge branch 'master' into Timob_19040
hansemannn 4736fc0
Merge branch 'master' into Timob_19040
ewieberappc 3088d1b
Merge branch 'master' into Timob_19040
ewieberappc File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -305,6 +305,10 @@ events: | |
platforms: [android] | ||
|
||
- name: fullscreen | ||
deprecated: | ||
since: "7.0.0" | ||
notes: This event has been removed in Titanium SDK 7.0.0 as of the official deprecation by Apple. | ||
removed: "7.0.0" | ||
summary: Fired when a movie changes to or from fullscreen view. | ||
description: | | ||
On iOS, this event is fired at the beginning of the transition to | ||
|
@@ -374,6 +378,10 @@ events: | |
constants: Titanium.Media.VIDEO_PLAYBACK_STATE_* | ||
|
||
- name: mediatypesavailable | ||
deprecated: | ||
since: "7.0.0" | ||
notes: This event has been removed in Titanium SDK 7.0.0 as of the official deprecation by Apple. | ||
removed: "7.0.0" | ||
summary: Fired when the media types in the current movie are determined. | ||
platforms: [iphone, ipad] | ||
properties: | ||
|
@@ -432,6 +440,10 @@ events: | |
summary: New `sourceType` value. | ||
|
||
- name: sourcechange | ||
deprecated: | ||
since: "7.0.0" | ||
notes: This event has been removed in Titanium SDK 7.0.0 as of the official deprecation by Apple. | ||
removed: "7.0.0" | ||
summary: | | ||
Fired when the [sourceType](Titanium.Media.VideoPlayer.sourceType) property | ||
changes. | ||
|
@@ -536,6 +548,9 @@ properties: | |
default: true | ||
|
||
- name: backgroundView | ||
deprecated: | ||
since: "7.0.0" | ||
notes: Use <Titanium.Media.VideoPlayer.overlayView> instead. | ||
summary: Sets the background view for customization which is always displayed behind movie content. | ||
description: | | ||
To create a background behind the movie content on iOS, you can specify a | ||
|
@@ -601,6 +616,10 @@ properties: | |
type: Number | ||
|
||
- name: fullscreen | ||
deprecated: | ||
since: "7.0.0" | ||
notes: This method has been removed for iOS in Titanium SDK 7.0.0 as of the official deprecation by Apple. | ||
removed: "7.0.0" | ||
summary: | | ||
Determines if the movie is presented in the entire screen (obscuring all other application content). | ||
description: | | ||
|
@@ -625,6 +644,9 @@ properties: | |
type: Number | ||
|
||
- name: loadState | ||
deprecated: | ||
since: "7.0.0" | ||
notes: On iOS, use <Titanium.Media.VideoPlayer.moviePlayerStatus> instead. | ||
summary: Returns the network load state of the movie player. | ||
type: Number | ||
permission: read-only | ||
|
@@ -636,6 +658,10 @@ properties: | |
permission: write-only | ||
|
||
- name: mediaControlStyle | ||
deprecated: | ||
since: "7.0.0" | ||
notes: On iOS, use <Titanium.Media.VideoPlayer.showsControls> instead. | ||
removed: "7.0.0" | ||
summary: The style of the playback controls. | ||
description: | | ||
Mobile web only supports <Titanium.Media.VIDEO_CONTROL_NONE> and | ||
|
@@ -674,6 +700,12 @@ properties: | |
ios: | ||
max: "3.1" | ||
|
||
- name: moviePlayerStatus | ||
summary: Returns the status of the movie player. | ||
type: Number | ||
permission: read-only | ||
platforms: [iphone, ipad] | ||
|
||
- name: naturalSize | ||
summary: Returns the natural size of the movie. | ||
description: | | ||
|
@@ -685,6 +717,37 @@ properties: | |
platforms: [iphone, ipad] | ||
type: MovieSize | ||
|
||
- name: overlayView | ||
summary: Use the overlay view to add additional custom views between the video content and the controls. | ||
description: | | ||
Note that the overlay view must be sized explicitly: percentage sizes do not work properly. | ||
|
||
The following code sample creates a video player with a background image: | ||
|
||
var videoPlayer = Ti.Media.createVideoPlayer({ | ||
height : 300, | ||
width : 300, | ||
overlayView : Ti.UI.createView({ | ||
backgroundImage: 'videoPlayerBG.png | ||
width : 300, | ||
height : 300 | ||
}), | ||
borderRadius : 20, | ||
borderWidth : 2, | ||
borderColor : 'blue', | ||
}); | ||
platforms: [iphone, ipad] | ||
type: Titanium.UI.View | ||
|
||
- name: pictureInPictureEnabled | ||
summary: Whether or not the receiver allows Picture in Picture playback | ||
platforms: [iphone, ipad] | ||
type: Boolean | ||
default: true | ||
osver: | ||
ios: | ||
max: "9.0" | ||
|
||
- name: playableDuration | ||
summary: | | ||
Currently playable duration of the movie, in milliseconds, for progressively | ||
|
@@ -709,8 +772,13 @@ properties: | |
permission: read-only | ||
|
||
- name: repeatMode | ||
summary: Determines how the movie player repeats when reaching the end of playback. | ||
deprecated: | ||
since: "7.0.0" | ||
notes: This method has been removed for iOS in Titanium SDK 7.0.0 as of the official deprecation by Apple. | ||
removed: "7.0.0" | ||
summary: Determines how the movie player repeats when reaching the end of playback. | ||
platforms: [android, iphone, ipad] | ||
|
||
type: Number | ||
constants: Titanium.Media.VIDEO_REPEAT_MODE_* | ||
default: Titanium.Media.VIDEO_REPEAT_MODE_NONE | ||
|
@@ -725,8 +793,23 @@ properties: | |
constants: Titanium.Media.VIDEO_SCALING_* | ||
default: <Titanium.Media.VIDEO_SCALING_ASPECT_FIT> | ||
|
||
- name: showsControls | ||
summary: Whether or not the receiver shows playback controls. Default is YES. | ||
description: | | ||
Clients can set this property to NO when they don't want to have any playback controls on top of | ||
the visual content (e.g. for a game splash screen). This property should not be used to temporarily | ||
change the visibility of the playback controls since it will create or destroy UI elements. | ||
platforms: [iphone, ipad] | ||
type: Boolean | ||
default: true | ||
since: "7.0.0" | ||
|
||
- name: sourceType | ||
summary: The playback type of the movie. | ||
deprecated: | ||
since: "7.0.0" | ||
notes: This method has been removed in Titanium SDK 7.0.0 as of the official deprecation by Apple. | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Add: notes: |
This method has been removed in Titanium SDK 7.0.0 as of the official deprecation by Apple.
The source type is detected automatically in the newer Apple API's used. |
||
removed: "7.0.0" | ||
summary: The playback type of the movie. | ||
description: | | ||
Specifying a playback type before playing the movie can result in faster load times. | ||
|
||
|
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am wondering how this passes linting. Some notes:
osver: {ios: {min: "9.0"}}
.
afterplayback