New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[TIMOB-25591] Android: Programmatically check whether app has notification permission on Android. #9669
Conversation
Generated by 🚫 dangerJS |
summary: Returns whether showing notifications is enabled for the application. | ||
returns: | ||
type: Boolean | ||
since: "7.1.0" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We need more parity for push notifications. Why not use remoteNotificationsEnabled?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That option will also block local notifications, so that wording would not describe it's full effect.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
CR: PASS
@ypbnv But test case needs updating due to lint errors.
FR Passed.
Studio Ver: 5.0.0.201712081732 |
JIRA: https://jira.appcelerator.org/browse/TIMOB-25591
Description:
Expose NotificationManagerCompat.areNotificationsEnabled method.
Note: Different results from this property are returned after a change has been made outside JS runtime, so maybe only check for the default value in a unit test ( I assume it is true by default )?
Test case:
app.js