Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[TIMOB-25591] Android: Programmatically check whether app has notification permission on Android. #9669

Merged
merged 12 commits into from
Feb 26, 2018
Merged

[TIMOB-25591] Android: Programmatically check whether app has notification permission on Android. #9669

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
099b9ff
Expose NotificationManagerCompat.areNotificationsEnabled method.
ypbnv Dec 8, 2017
7930bf4
Add docs.
ypbnv Dec 8, 2017
0e6ef4c
Fix format.
ypbnv Dec 8, 2017
3ad208c
Merge branch 'master' into TIMOB-25591
ypbnv Jan 3, 2018
d3935bb
Test for default value of areNotificationsEnabled().
ypbnv Jan 4, 2018
31db323
Merge branch 'master' into TIMOB-25591
ypbnv Jan 4, 2018
58b50cb
Merge branch 'master' into TIMOB-25591
ypbnv Jan 10, 2018
87092b8
Merge branch 'master' into TIMOB-25591
ypbnv Feb 13, 2018
48a69e9
Merge branch 'master' into TIMOB-25591
ypbnv Feb 15, 2018
90284bf
Lint unit test.
ypbnv Feb 15, 2018
3c85dc7
Merge branch 'master' into TIMOB-25591
ypbnv Feb 19, 2018
57dcd53
Merge branch 'master' into TIMOB-25591
Feb 26, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
7 changes: 7 additions & 0 deletions ...d/src/java/ti/modules/titanium/android/notificationmanager/NotificationManagerModule.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,7 @@
import android.os.Build;
import android.os.PowerManager;
import android.os.PowerManager.WakeLock;
import android.support.v4.app.NotificationManagerCompat;

import java.util.HashMap;

Expand Down Expand Up @@ -113,6 +114,12 @@ public void notify(int id, NotificationProxy notificationProxy)
}
}

@Kroll.method
public boolean areNotificationsEnabled()
{
return NotificationManagerCompat.from(TiApplication.getInstance()).areNotificationsEnabled();
}

@Override
public String getApiName()
{
Expand Down
6 changes: 6 additions & 0 deletions apidoc/Titanium/Android/NotificationManager/NotificationManager.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,6 +48,12 @@ methods:
returns:
type: Titanium.Android.NotificationChannel

- name: areNotificationsEnabled
summary: Returns whether showing notifications is enabled for the application.
returns:
type: Boolean
since: "7.1.0"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need more parity for push notifications. Why not use remoteNotificationsEnabled?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That option will also block local notifications, so that wording would not describe it's full effect.


properties:

- name: DEFAULT_ALL
Expand Down