Android: Fixed picker spinner to size/position columns correctly on Android 5.0 and higher #9674
Conversation
Adjust canvas translate offset
Generated by 🚫 dangerJS |
|
Leading to different result on API 25 & 26. |
| if (Build.VERSION.SDK_INT < 21) { | ||
| translateY = -getItemOffset(); | ||
| } else { | ||
| translateY = 0; |
There was a problem hiding this comment.
Maggie, this UI widget still has offset issues on API Levels > 21, right? I think we should by translating by the value returned by getTextSize() for the higher API Levels. This is because we offset it by text size here.
That is, it should look like this...
if (Build.VERSION.SDK_INT < 21) {
translateY = -getItemOffset();
} else {
translateY = getTextSize() / 2.0f;
}Can you give the above a go please?
|
@jquick-axway This is my testing result comparing the translateY. Not sure if it is showing different result on your devices? |
jquick-axway
changed the title
…n Android 5.0 and higher.
|
Updated PR. Spinner sizing/positioning issues on Android 5.0 and higher is now fixed. |
|
FR Passed. Picker spinner columns size/position as expected. Studio Ver: 5.1.0.201804230827 |
JIRA:
https://jira.appcelerator.org/browse/TIMOB-19822
Test:
SpinnerTest.jsfile attached to TIMOB-19822 on Android 5.0 or higher.SpinnerTest-good.pngattached to TIMOB-19822 for an idea of what spinners should look like.