Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Android: Fixed picker spinner to size/position columns correctly on Android 5.0 and higher #9674

Merged
merged 7 commits into from
May 11, 2018
Merged

Android: Fixed picker spinner to size/position columns correctly on Android 5.0 and higher #9674

Changes from 2 commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
8d4ad90
Update WheelView.java
maggieaxway Dec 11, 2017
7765a7d
Update offset for API >=21
maggieaxway Dec 11, 2017
0a5aec1
Compensate offset for API>21
maggieaxway Jan 2, 2018
4142fee
Merge branch 'master' into TIMOB-19822
jquick-axway May 8, 2018
0be01a9
Android: Final fixes for [TIMOB-19822] picker spinner sizing issues o…
jquick-axway May 9, 2018
9dda04b
Merge branch 'master' into Timob-19822
lokeshchdhry May 10, 2018
7272f9f
Merge branch 'master' into Timob-19822
lokeshchdhry May 11, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
8 changes: 7 additions & 1 deletion android/modules/ui/src/java/kankan/wheel/widget/WheelView.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -589,7 +589,13 @@ protected void onDraw(Canvas canvas) {
if (itemsWidth > 0) {
canvas.save();
// Skip padding space and hide a part of top and bottom items
canvas.translate(PADDING, -getItemOffset());
float translateY;
if (Build.VERSION.SDK_INT < 21) {
translateY = -getItemOffset();
} else {
translateY = 0;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maggie, this UI widget still has offset issues on API Levels > 21, right? I think we should by translating by the value returned by getTextSize() for the higher API Levels. This is because we offset it by text size here.

That is, it should look like this...

if (Build.VERSION.SDK_INT < 21) {
	translateY = -getItemOffset();
} else {
	translateY = getTextSize() / 2.0f;
}

Can you give the above a go please?

}
canvas.translate(PADDING, translateY);
drawItems(canvas);
drawValue(canvas);
canvas.restore();
Expand Down