Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[TIMOB-25769] Android: Fix WebView content selection intent #9820

Merged
merged 3 commits into from Feb 20, 2018
Merged

[TIMOB-25769] Android: Fix WebView content selection intent #9820

merged 3 commits into from Feb 20, 2018

Conversation

garymathews
Copy link
Contributor

  • Fix content selection intent to allow all formats
TEST CASE
var win = Ti.UI.createWindow(),
    web = Ti.UI.createWebView({ url: 'https://expirebox.com/' });

// download http://download.blender.org/peach/bigbuckbunny_movies/BigBuckBunny_320x180.mp4
// and attempt to upload

win.add(web);
win.open();

JIRA Ticket

@garymathews garymathews added this to the 7.1.0 milestone Feb 13, 2018
@build
Copy link
Contributor

build commented Feb 13, 2018 •
edited

Messages
📖

💾 Here's the generated SDK zipfile.

Generated by 🚫 dangerJS

@garymathews garymathews mentioned this pull request Feb 13, 2018
Closed
ypbnv
ypbnv approved these changes Feb 14, 2018
View reviewed changes
Copy link
Contributor

@ypbnv ypbnv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CR: Pass

@garymathews garymathews mentioned this pull request Feb 15, 2018
Merged
@build build added the android label Feb 16, 2018
@hansemannn hansemannn modified the milestones: 7.1.0, 7.2.0 Feb 18, 2018
@build build added the android label Feb 20, 2018
@lokeshchdhry
Copy link
Contributor

FR Passed.

File upload works as expected from webview.

Studio Ver: 5.0.0.201712081732
SDK Ver: 7.2.0 local build
OS Ver: 10.13.2
Xcode Ver: Xcode 9.2
Appc NPM: 4.2.12
Appc CLI: 7.0.2
Daemon Ver: 1.0.1
Ti CLI Ver: 5.0.14
Alloy Ver: 1.11.0
Node Ver: 8.9.1
NPM Ver: 5.5.1
Java Ver: 1.8.0_101
Devices: ⇨ google Nexus 5 --- Android 6.0.1
⇨ google Nexus 6P --- Android 8.0.0

@lokeshchdhry lokeshchdhry merged commit d48d320 into tidev:master Feb 20, 2018
@sgtcoolguy sgtcoolguy modified the milestones: 7.2.0, 7.3.0 May 16, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ypbnv ypbnv ypbnv approved these changes

Assignees
No one assigned
Labels
android bug in-qe-testing 🕵 no tests
Projects
None yet
Milestone
7.3.0
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@garymathews @build @lokeshchdhry @ypbnv @sgtcoolguy @hansemannn