Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[TIMOB-25769] Android: Allow video-upload in Ti.UI.WebView #9811

Closed
wants to merge 1 commit into from
Closed

[TIMOB-25769] Android: Allow video-upload in Ti.UI.WebView #9811

wants to merge 1 commit into from

Conversation

SquirrelMobile
Copy link

@SquirrelMobile SquirrelMobile commented Feb 7, 2018 •
edited by hansemannn

@build
Copy link
Contributor

build commented Feb 7, 2018

Fails
🚫

🔬 There are library changes, but no changes to the unit tests. That's OK as long as you're refactoring existing code, but will require an admin to merge this PR. Please see README.md#unit-tests for docs on unit testing.
Messages
📖

👍 Hey!, You deleted more code than you added. That's awesome!
📖

🎊 Welcome to the Titanium SDK community, SquirrelMobile! Thank you so much for your PR, you're helping us make Titanium better. 🎁
📖

💾 Here's the generated SDK zipfile.

Generated by 🚫 dangerJS

@hansemannn hansemannn changed the title change type to upload Video or other format than image on form upload [AC-5581] Android: Change type to upload Video or other format than image on form upload Feb 10, 2018
@hansemannn hansemannn changed the title [AC-5581] Android: Change type to upload Video or other format than image on form upload [TIMOB-25769] Android: Allow video-upload in Ti.UI.WebView Feb 10, 2018
@hansemannn
Copy link
Collaborator

@SquirrelMobile The PR is currently made against 7_0_X, but has to be against master. We'll eventually close this one and move it to master.

@garymathews
Copy link
Contributor

Closing, succeeded by #9820

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
android community 🔥 needs cla 🚨 needs tests 🚨
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@SquirrelMobile @build @hansemannn @garymathews