Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TIMOB-25819] Android: ScrollView starts at the wrong location if it contains a ListView #9901

Merged
merged 4 commits into from May 24, 2018

Conversation

ypbnv
Copy link
Contributor

@ypbnv ypbnv commented Mar 2, 2018

JIRA: https://jira.appcelerator.org/browse/TIMOB-25819

Description:
Prevent ScrollView's children to get focus after drawing in order to keep it at page's top (as in iOS).

@build
Copy link
Contributor

build commented Mar 2, 2018

Fails
🚫

🔬 There are library changes, but no changes to the unit tests. That's OK as long as you're refactoring existing code, but will require an admin to merge this PR. Please see README.md#unit-tests for docs on unit testing.

Messages
📖

👍 Hey!, You deleted more code than you added. That's awesome!

📖

💾 Here's the generated SDK zipfile.

Generated by 🚫 dangerJS

@lokeshchdhry
Copy link
Contributor

@ypbnv , Can you please resolve the conflicts.

# Conflicts:
#	android/modules/ui/src/java/ti/modules/titanium/ui/widget/TiUIScrollView.java
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants